This is a note to let you know that I've just added the patch titled Revert "btrfs: add dmesg output for first mount and last unmount of a filesystem" to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-btrfs-add-dmesg-output-for-first-mount-and-last-unmount-of-a-filesystem.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 910164f3394f3f2036b5655eae72c49f9b0ad800 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Mon, 11 Dec 2023 15:52:30 +0100 Subject: Revert "btrfs: add dmesg output for first mount and last unmount of a filesystem" From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> This reverts commit dd94ffab1b6d84b3ba9a8d09b6b0f44610d397eb which is commit 2db313205f8b96eea467691917138d646bb50aef upstream. As pointed out by many, the disk_super structure is NOT initialized before it is dereferenced in the function fs/btrfs/disk-io.c:open_ctree() that this commit adds, so something went wrong here. Revert it for now until it gets straightened out. Link: https://lore.kernel.org/r/5b0eb360-3765-40e1-854a-9da6d97eb405@xxxxxxxxxxxx Link: https://lore.kernel.org/r/20231209172836.GA2154579@dev-arch.thelio-3990X Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx> Cc: Anand Jain <anand.jain@xxxxxxxxxx> Cc: Qu Wenruo <wqu@xxxxxxxx> Cc: David Sterba <dsterba@xxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/btrfs/disk-io.c | 1 - fs/btrfs/super.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2829,7 +2829,6 @@ int open_ctree(struct super_block *sb, goto fail_alloc; } - btrfs_info(fs_info, "first mount of filesystem %pU", disk_super->fsid); /* * Verify the type first, if that or the checksum value are * corrupted, we'll find out --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -291,10 +291,7 @@ void __btrfs_panic(struct btrfs_fs_info static void btrfs_put_super(struct super_block *sb) { - struct btrfs_fs_info *fs_info = btrfs_sb(sb); - - btrfs_info(fs_info, "last unmount of filesystem %pU", fs_info->fs_devices->fsid); - close_ctree(fs_info); + close_ctree(btrfs_sb(sb)); } enum { Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-5.4/tracing-fix-a-possible-race-when-disabling-buffered-events.patch queue-5.4/parport-add-support-for-brainboxes-ix-uc-px-parallel-cards.patch queue-5.4/psample-require-cap_net_admin-when-joining-packets-group.patch queue-5.4/alsa-pcm-fix-out-of-bounds-in-snd_pcm_state_names.patch queue-5.4/serial-8250_omap-add-earlycon-support-for-the-am654-uart-controller.patch queue-5.4/arm64-dts-mediatek-mt7622-fix-memory-node-warning-check.patch queue-5.4/tools-headers-uapi-sync-linux-perf_event.h-with-the-kernel-sources.patch queue-5.4/drop_monitor-require-cap_sys_admin-when-joining-events-group.patch queue-5.4/tracing-fix-incomplete-locking-when-disabling-buffered-events.patch queue-5.4/serial-sc16is7xx-address-rx-timeout-interrupt-errata.patch queue-5.4/kvm-s390-mm-properly-reset-no-dat.patch queue-5.4/io_uring-af_unix-disable-sending-io_uring-over-sockets.patch queue-5.4/tracing-always-update-snapshot-buffer-size.patch queue-5.4/revert-btrfs-add-dmesg-output-for-first-mount-and-last-unmount-of-a-filesystem.patch queue-5.4/usb-typec-class-fix-typec_altmode_put_partner-to-put-plugs.patch queue-5.4/nilfs2-prevent-warning-in-nilfs_sufile_set_segment_usage.patch queue-5.4/netlink-don-t-call-netlink_bind-with-table-lock-held.patch queue-5.4/arm-pl011-fix-dma-support.patch queue-5.4/genetlink-add-cap_net_admin-test-for-multicast-bind.patch queue-5.4/arm64-dts-mediatek-mt8173-evb-fix-regulator-fixed-node-names.patch queue-5.4/x86-cpu-amd-check-vendor-in-the-amd-microcode-callback.patch queue-5.4/packet-move-reference-count-in-packet_sock-to-atomic_long_t.patch queue-5.4/usb-gadget-f_hid-fix-report-descriptor-allocation.patch queue-5.4/nilfs2-fix-missing-error-check-for-sb_set_blocksize-call.patch