This is a note to let you know that I've just added the patch titled
mmc: cqhci: Warn of halt or task clear failure
to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mmc-cqhci-warn-of-halt-or-task-clear-failure.patch
and it can be found in the queue-6.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 35597bdb04ec27ef3b1cea007dc69f8ff5df75a5 Mon Sep 17 00:00:00 2001
From: Adrian Hunter <adrian.hunter@xxxxxxxxx>
Date: Fri, 3 Nov 2023 10:47:19 +0200
Subject: mmc: cqhci: Warn of halt or task clear failure
From: Adrian Hunter <adrian.hunter@xxxxxxxxx>
commit 35597bdb04ec27ef3b1cea007dc69f8ff5df75a5 upstream.
A correctly operating controller should successfully halt and clear tasks.
Failure may result in errors elsewhere, so promote messages from debug to
warnings.
Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>
Link: https://lore.kernel.org/r/20231103084720.6886-6-adrian.hunter@xxxxxxxxx
Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/mmc/host/cqhci-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/mmc/host/cqhci-core.c
+++ b/drivers/mmc/host/cqhci-core.c
@@ -942,8 +942,8 @@ static bool cqhci_clear_all_tasks(struct
ret = cqhci_tasks_cleared(cq_host);
if (!ret)
- pr_debug("%s: cqhci: Failed to clear tasks\n",
- mmc_hostname(mmc));
+ pr_warn("%s: cqhci: Failed to clear tasks\n",
+ mmc_hostname(mmc));
return ret;
}
@@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *
ret = cqhci_halted(cq_host);
if (!ret)
- pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
+ pr_warn("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));
return ret;
}
Patches currently in stable-queue which might be from adrian.hunter@xxxxxxxxx are
queue-6.6/mmc-block-be-sure-to-wait-while-busy-in-cqe-error-recovery.patch
queue-6.6/mmc-block-do-not-lose-cache-flush-during-cqe-error-recovery.patch
queue-6.6/mmc-sdhci-pci-gli-disable-lpm-during-initialization.patch
queue-6.6/mmc-block-retry-commands-in-cqe-error-recovery.patch
queue-6.6/mmc-cqhci-warn-of-halt-or-task-clear-failure.patch
queue-6.6/mmc-cqhci-fix-task-clearing-in-cqe-error-recovery.patch
queue-6.6/mmc-cqhci-increase-recovery-halt-timeout.patch
