This is a note to let you know that I've just added the patch titled
USB: dwc3: qcom: fix software node leak on probe errors
to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-dwc3-qcom-fix-software-node-leak-on-probe-errors.patch
and it can be found in the queue-6.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 9feefbf57d92e8ee293dad67585d351c7d0b6e37 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan+linaro@xxxxxxxxxx>
Date: Fri, 17 Nov 2023 18:36:49 +0100
Subject: USB: dwc3: qcom: fix software node leak on probe errors
From: Johan Hovold <johan+linaro@xxxxxxxxxx>
commit 9feefbf57d92e8ee293dad67585d351c7d0b6e37 upstream.
Make sure to remove the software node also on (ACPI) probe errors to
avoid leaking the underlying resources.
Note that the software node is only used for ACPI probe so the driver
unbind tear down is updated to match probe.
Fixes: 8dc6e6dd1bee ("usb: dwc3: qcom: Constify the software node")
Cc: stable@xxxxxxxxxxxxxxx # 5.12
Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Acked-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20231117173650.21161-3-johan+linaro@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/dwc3/dwc3-qcom.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -949,10 +949,12 @@ static int dwc3_qcom_probe(struct platfo
interconnect_exit:
dwc3_qcom_interconnect_exit(qcom);
depopulate:
- if (np)
+ if (np) {
of_platform_depopulate(&pdev->dev);
- else
+ } else {
+ device_remove_software_node(&qcom->dwc3->dev);
platform_device_del(qcom->dwc3);
+ }
platform_device_put(qcom->dwc3);
free_urs:
if (qcom->urs_usb)
@@ -975,11 +977,12 @@ static void dwc3_qcom_remove(struct plat
struct device *dev = &pdev->dev;
int i;
- device_remove_software_node(&qcom->dwc3->dev);
- if (np)
+ if (np) {
of_platform_depopulate(&pdev->dev);
- else
+ } else {
+ device_remove_software_node(&qcom->dwc3->dev);
platform_device_del(qcom->dwc3);
+ }
platform_device_put(qcom->dwc3);
if (qcom->urs_usb)
Patches currently in stable-queue which might be from johan+linaro@xxxxxxxxxx are
queue-6.6/usb-dwc3-qcom-fix-resource-leaks-on-probe-deferral.patch
queue-6.6/usb-dwc3-qcom-fix-acpi-platform-device-leak.patch
queue-6.6/usb-dwc3-qcom-fix-wakeup-after-probe-deferral.patch
queue-6.6/revert-phy-realtek-usb-add-driver-for-the-realtek-soc-usb-2.0-phy.patch
queue-6.6/usb-xhci-plat-fix-legacy-phy-double-init.patch
queue-6.6/revert-usb-phy-add-usb-phy-notify-port-status-api.patch
queue-6.6/usb-dwc3-qcom-fix-software-node-leak-on-probe-errors.patch
queue-6.6/drm-msm-dpu-add-missing-safe_lut_tbl-in-sc8280xp-catalog.patch
queue-6.6/revert-phy-realtek-usb-add-driver-for-the-realtek-soc-usb-3.0-phy.patch
