This is a note to let you know that I've just added the patch titled
nfsd: fix file memleak on client_opens_release
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfsd-fix-file-memleak-on-client_opens_release.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From bc1b5acb40201a0746d68a7d7cfc141899937f4f Mon Sep 17 00:00:00 2001
From: Mahmoud Adam <mngyadam@xxxxxxxxxx>
Date: Fri, 10 Nov 2023 19:21:04 +0100
Subject: nfsd: fix file memleak on client_opens_release
From: Mahmoud Adam <mngyadam@xxxxxxxxxx>
commit bc1b5acb40201a0746d68a7d7cfc141899937f4f upstream.
seq_release should be called to free the allocated seq_file
Cc: stable@xxxxxxxxxxxxxxx # v5.3+
Signed-off-by: Mahmoud Adam <mngyadam@xxxxxxxxxx>
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
Fixes: 78599c42ae3c ("nfsd4: add file to display list of client's opens")
Reviewed-by: NeilBrown <neilb@xxxxxxx>
Tested-by: Jeff Layton <jlayton@xxxxxxxxxx>
Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2647,7 +2647,7 @@ static int client_opens_release(struct i
/* XXX: alternatively, we could get/drop in seq start/stop */
drop_client(clp);
- return 0;
+ return seq_release(inode, file);
}
static const struct file_operations client_states_fops = {
Patches currently in stable-queue which might be from mngyadam@xxxxxxxxxx are
queue-5.10/nfsd-fix-file-memleak-on-client_opens_release.patch
