Patch "serial: meson: remove redundant initialization of variable id" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    serial: meson: remove redundant initialization of variable id

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     serial-meson-remove-redundant-initialization-of-vari.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit cf31acecb91ddeab131652ce81975d8a28f641a5
Author: Colin Ian King <colin.i.king@xxxxxxxxx>
Date:   Mon Apr 26 11:11:06 2021 +0100

    serial: meson: remove redundant initialization of variable id
    
    [ Upstream commit 021212f5335229ed12e3d31f9b7d30bd3bb66f7d ]
    
    The variable id being initialized with a value that is never read
    and it is being updated later with a new value. The initialization is
    redundant and can be removed. Since id is just being used in a for-loop
    inside a local scope, move the declaration of id to that scope.
    
    Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
    Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
    Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
    Addresses-Coverity: ("Unused value")
    Link: https://lore.kernel.org/r/20210426101106.9122-1-colin.king@xxxxxxxxxxxxx
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Stable-dep-of: 2a1d728f20ed ("tty: serial: meson: fix hard LOCKUP on crtscts mode")
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 91b7359b79a2f..d06653493f0ef 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -729,12 +729,13 @@ static int meson_uart_probe(struct platform_device *pdev)
 	struct resource *res_mem, *res_irq;
 	struct uart_port *port;
 	int ret = 0;
-	int id = -1;
 
 	if (pdev->dev.of_node)
 		pdev->id = of_alias_get_id(pdev->dev.of_node, "serial");
 
 	if (pdev->id < 0) {
+		int id;
+
 		for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) {
 			if (!meson_ports[id]) {
 				pdev->id = id;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux