Patch "arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side" has been added to the 6.5-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side

to the 6.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     arm64-dts-qcom-sc7280-drop-incorrect-eud-port-on-soc.patch
and it can be found in the queue-6.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 96b5c52d3ba7b812a378feb11be195ec8098fe1b
Author: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Date:   Sun Aug 20 09:56:26 2023 +0200

    arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side
    
    [ Upstream commit 39c8af78cbefb8c71a5ad1fa088e761ef418f0a0 ]
    
    Qualcomm Embedded USB Debugger (EUD) second port should point to Type-C
    USB connector.  Such connector was defined directly in root node of
    sc7280.dtsi which is clearly wrong.  SC7280 is a chip, so physically it
    does not have USB Type-C port.  The connector is usually accessible
    through some USB switch or controller.
    
    Doug Anderson said that he wasn't ever able to use EUD on Herobrine
    boards, probably because of invalid or missing DTS description - DTS is
    saying EUD is on usb_2 node, which is connected to a USB Hub, not to the
    Type-C port.
    
    Correct the EUD/USB connector topology by removing the top-level fake
    USB connector and EUD port pointing to it, and disabling the incomplete
    EUD device node.
    
    This fixes also dtbs_check warnings:
    
      sc7280-herobrine-crd.dtb: connector: ports:port@0: 'reg' is a required property
    
    Link: https://lore.kernel.org/all/CAD=FV=Xt26=rBf99mzkAuwwtb2f-jnKtnHaEhXnthz0a5zke4Q@xxxxxxxxxxxxxx/
    Fixes: 9ee402ccfeb1 ("arm64: dts: qcom: sc7280: Fix EUD dt node syntax")
    Cc: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
    Cc: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
    Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/20230820075626.22600-1-krzysztof.kozlowski@xxxxxxxxxx
    Signed-off-by: Bjorn Andersson <andersson@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 20231d80c504b..91bb58c6b1a61 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -649,18 +649,6 @@ cpu7_opp_3014mhz: opp-3014400000 {
 		};
 	};
 
-	eud_typec: connector {
-		compatible = "usb-c-connector";
-
-		ports {
-			port@0 {
-				con_eud: endpoint {
-					remote-endpoint = <&eud_con>;
-				};
-			};
-		};
-	};
-
 	memory@80000000 {
 		device_type = "memory";
 		/* We expect the bootloader to fill in the size */
@@ -3625,6 +3613,8 @@ eud: eud@88e0000 {
 			      <0 0x88e2000 0 0x1000>;
 			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
 
+			status = "disabled";
+
 			ports {
 				#address-cells = <1>;
 				#size-cells = <0>;
@@ -3635,13 +3625,6 @@ eud_ep: endpoint {
 						remote-endpoint = <&usb2_role_switch>;
 					};
 				};
-
-				port@1 {
-					reg = <1>;
-					eud_con: endpoint {
-						remote-endpoint = <&con_eud>;
-					};
-				};
 			};
 		};