Patch "media: platform: mtk-mdp3: fix uninitialized variable in mdp_path_config()" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    media: platform: mtk-mdp3: fix uninitialized variable in mdp_path_config()

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     media-platform-mtk-mdp3-fix-uninitialized-variable-i.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 1153cd82ba84d68863e552a3294b48d72ce9de95
Author: Moudy Ho <moudy.ho@xxxxxxxxxxxx>
Date:   Wed Oct 11 11:00:37 2023 +0800

    media: platform: mtk-mdp3: fix uninitialized variable in mdp_path_config()
    
    [ Upstream commit 2a76e7679b594ea3e1b3b7fb6c3d67158114020d ]
    
    Fix the build warnings that were detected by the linux-media
    build scripts tool:
    
    drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:
            In function 'mdp_path_config.isra':
    drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:
            warning: 'ctx' may be used uninitialized [-Wmaybe-uninitialized]
          |                    out = CFG_COMP(MT8195, ctx->param, outputs[0]);
          |                                           ~~~^~~~~~~
    drivers/media/platform/mediatek/mdp3/mtk-img-ipi.h: note:
            in definition of macro 'CFG_COMP'
          |         (IS_ERR_OR_NULL(comp) ? 0 : _CFG_COMP(plat, comp, mem))
          |                         ^~~~
    drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c:
            note: 'ctx' was declared here
          |         struct mdp_comp_ctx *ctx;
          |
    
    Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
    Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
index 3177592490bee..6adac857a4779 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
@@ -261,11 +261,11 @@ static int mdp_path_config(struct mdp_dev *mdp, struct mdp_cmdq_cmd *cmd,
 		const struct v4l2_rect *compose;
 		u32 out = 0;
 
+		ctx = &path->comps[index];
 		if (CFG_CHECK(MT8183, p_id))
 			out = CFG_COMP(MT8183, ctx->param, outputs[0]);
 
 		compose = path->composes[out];
-		ctx = &path->comps[index];
 		ret = call_op(ctx, config_frame, cmd, compose);
 		if (ret)
 			return ret;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux