This is a note to let you know that I've just added the patch titled
vdpa_sim_blk: Fix the potential leak of mgmt_dev
to the 6.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
vdpa_sim_blk-fix-the-potential-leak-of-mgmt_dev.patch
and it can be found in the queue-6.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From d121df789b159e9a8ee770666f210975a81e8111 Mon Sep 17 00:00:00 2001
From: "Shawn.Shao" <shawn.shao@xxxxxxxxxxxxxxx>
Date: Mon, 21 Aug 2023 14:03:33 +0800
Subject: vdpa_sim_blk: Fix the potential leak of mgmt_dev
From: Shawn.Shao <shawn.shao@xxxxxxxxxxxxxxx>
commit d121df789b159e9a8ee770666f210975a81e8111 upstream.
If the shared_buffer allocation fails, need to unregister mgmt_dev first.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: abebb16254b36 ("vdpa_sim_blk: support shared backend")
Signed-off-by: Shawn.Shao <shawn.shao@xxxxxxxxxxxxxxx>
Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
Message-Id: <20230821060333.1155-1-shawn.shao@xxxxxxxxxxxxxxx>
Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
index 00d7d72713be..b3a3cb165795 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
@@ -499,12 +499,13 @@ static int __init vdpasim_blk_init(void)
GFP_KERNEL);
if (!shared_buffer) {
ret = -ENOMEM;
- goto parent_err;
+ goto mgmt_dev_err;
}
}
return 0;
-
+mgmt_dev_err:
+ vdpa_mgmtdev_unregister(&mgmt_dev);
parent_err:
device_unregister(&vdpasim_blk_mgmtdev);
return ret;
--
2.42.0
Patches currently in stable-queue which might be from shawn.shao@xxxxxxxxxxxxxxx are
queue-6.5/vdpa_sim_blk-fix-the-potential-leak-of-mgmt_dev.patch
