Patch "ASoC: SOF: amd: fix for firmware reload failure after playback" has been added to the 6.5-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ASoC: SOF: amd: fix for firmware reload failure after playback

to the 6.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     asoc-sof-amd-fix-for-firmware-reload-failure-after-p.patch
and it can be found in the queue-6.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 7233d901cac85d61e91fad5f10148c341def5a10
Author: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
Date:   Wed Sep 27 12:44:10 2023 +0530

    ASoC: SOF: amd: fix for firmware reload failure after playback
    
    [ Upstream commit 7e1fe5d9e7eae67e218f878195d1d348d01f9af7 ]
    
    Setting ACP ACLK as clock source when ACP enters D0 state causing
    firmware load failure as mentioned in below scenario.
    
    - Load snd_sof_amd_rembrandt
    - Play or Record audio
    - Stop audio
    - Unload snd_sof_amd_rembrandt
    - Reload snd_sof_amd_rembrandt
    
    If acp_clkmux_sel register field is set, then clock source will be
    set to ACP ACLK when ACP enters D0 state.
    
    During stream stop, if there is no active stream is running then
    acp firmware will set the ACP ACLK value to zero.
    
    When driver is reloaded and clock source is selected as ACP ACLK,
    as ACP ACLK is programmed to zero, firmware loading will fail.
    
    For RMB platform, remove the clock mux selection field so that
    ACP will use internal clock source when ACP enters D0 state.
    
    Fixes: 41cb85bc4b52 ("ASoC: SOF: amd: Add support for Rembrandt plaform.")
    Reported-by: coolstar <coolstarorganization@xxxxxxxxx>
    Closes: https://github.com/thesofproject/sof/issues/8137
    Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
    Link: https://lore.kernel.org/r/20230927071412.2416250-1-Vijendar.Mukunda@xxxxxxx
    Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/sound/soc/sof/amd/pci-rmb.c b/sound/soc/sof/amd/pci-rmb.c
index 58b3092425f1a..874230ffcbcc6 100644
--- a/sound/soc/sof/amd/pci-rmb.c
+++ b/sound/soc/sof/amd/pci-rmb.c
@@ -34,7 +34,6 @@ static const struct sof_amd_acp_desc rembrandt_chip_info = {
 	.dsp_intr_base	= ACP6X_DSP_SW_INTR_BASE,
 	.sram_pte_offset = ACP6X_SRAM_PTE_OFFSET,
 	.hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0,
-	.acp_clkmux_sel = ACP6X_CLKMUX_SEL,
 	.fusion_dsp_offset = ACP6X_DSP_FUSION_RUNSTALL,
 };
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux