This is a note to let you know that I've just added the patch titled
Revert "rtnetlink: Reject negative ifindexes in RTM_NEWLINK"
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 8d271d77834f96bd04ff3a29eb688d4364eec009 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 9 Oct 2023 20:25:00 +0200
Subject: Revert "rtnetlink: Reject negative ifindexes in RTM_NEWLINK"
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
This reverts commit 42c8406432e730cb7442d97ecfdbf47084a5af4d which is
commit 30188bd7838c16a98a520db1fe9df01ffc6ed368 upstream.
It was improperly backported to 4.19.y, and applied to the wrong
function, which obviously causes problems. A fixed version will be
applied as a separate commit later.
Reported-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Link: https://lore.kernel.org/r/ZSQeA8fhUT++iZvz@ostr-mac
Cc: Ido Schimmel <idosch@xxxxxxxxxx>
Cc: Jiri Pirko <jiri@xxxxxxxxxx>
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
Cc: Sasha Levin <sashal@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/core/rtnetlink.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2702,10 +2702,7 @@ static int rtnl_setlink(struct sk_buff *
ifm = nlmsg_data(nlh);
if (ifm->ifi_index > 0)
dev = __dev_get_by_index(net, ifm->ifi_index);
- else if (ifm->ifi_index < 0) {
- NL_SET_ERR_MSG(extack, "ifindex can't be negative");
- return -EINVAL;
- } else if (tb[IFLA_IFNAME])
+ else if (tb[IFLA_IFNAME])
dev = __dev_get_by_name(net, ifname);
else
goto errout;
Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are
queue-4.19/nilfs2-fix-potential-use-after-free-in-nilfs_gccache_submit_read_data.patch
queue-4.19/revert-pci-qcom-disable-write-access-to-read-only-registers-for-ip-v2.3.3.patch
queue-4.19/rdma-mlx5-fix-null-string-error.patch
queue-4.19/i2c-i801-unregister-tco_pdev-in-i801_probe-error-path.patch
queue-4.19/ata-libata-sata-increase-pmp-srst-timeout-to-10s.patch
queue-4.19/gpio-pxa-disable-pinctrl-calls-for-mmp_gpio.patch
queue-4.19/rdma-cma-fix-truncation-compilation-warning-in-make_cma_ports.patch
queue-4.19/revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch
queue-4.19/gpio-aspeed-fix-the-gpio-number-passed-to-pinctrl_gpio_set_config.patch
queue-4.19/fs-binfmt_elf_efpic-fix-personality-for-elf-fdpic.patch
queue-4.19/media-dvb-symbol-fixup-for-dvb_attach-again.patch
queue-4.19/qed-red_ll2-fix-undefined-behavior-bug-in-struct-qed_ll2_info.patch
queue-4.19/ata-libata-core-fix-port-and-device-removal.patch
queue-4.19/btrfs-properly-report-0-avail-for-very-full-file-systems.patch
queue-4.19/dccp-fix-dccp_v4_err-dccp_v6_err-again.patch
queue-4.19/ata-libata-core-do-not-register-pm-operations-for-sas-ports.patch
queue-4.19/revert-drivers-core-use-sysfs_emit-and-sysfs_emit_at-for-show-device-...-functions.patch
queue-4.19/ib-mlx4-fix-the-size-of-a-buffer-in-add_port_entries.patch
queue-4.19/parisc-restore-__ldcw_align-for-pa-risc-2.0-processors.patch
queue-4.19/ext4-fix-rec_len-verify-error.patch
queue-4.19/ata-libata-disallow-dev-initiated-lpm-transitions-to-unsupported-states.patch
queue-4.19/btrfs-reject-unknown-mount-options-early.patch
queue-4.19/net-replace-calls-to-sock-ops-connect-with-kernel_connect.patch
queue-4.19/cpupower-add-makefile-dependencies-for-install-targets.patch
queue-4.19/alsa-hda-disable-power-save-for-solving-pop-issue-on-lenovo-thinkcentre-m70q.patch
queue-4.19/net-thunderbolt-fix-tcpv6-gso-checksum-calculation.patch
queue-4.19/ata-libata-scsi-ignore-reserved-bits-for-report-supported-operation-codes.patch
queue-4.19/wifi-mwifiex-fix-tlv_buf_left-calculation.patch
queue-4.19/scsi-zfcp-fix-a-double-put-in-zfcp_port_enqueue.patch
queue-4.19/ata-libata-core-fix-ata_port_request_pm-locking.patch
queue-4.19/serial-8250_port-check-irq-data-before-use.patch
