Patch "NFSv4.1: fix zero value filehandle in post open getattr" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    NFSv4.1: fix zero value filehandle in post open getattr

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     nfsv4.1-fix-zero-value-filehandle-in-post-open-getat.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit cd65dc625a065f70c89cbd08884f8c211775d762
Author: Olga Kornievskaia <kolga@xxxxxxxxxx>
Date:   Thu Jul 13 15:54:16 2023 -0400

    NFSv4.1: fix zero value filehandle in post open getattr
    
    [ Upstream commit 4506f23e117161a20104c8fa04f33e1ca63c26af ]
    
    Currently, if the OPEN compound experiencing an error and needs to
    get the file attributes separately, it will send a stand alone
    GETATTR but it would use the filehandle from the results of
    the OPEN compound. In case of the CLAIM_FH OPEN, nfs_openres's fh
    is zero value. That generate a GETATTR that's sent with a zero
    value filehandle, and results in the server returning an error.
    
    Instead, for the CLAIM_FH OPEN, take the filehandle that was used
    in the PUTFH of the OPEN compound.
    
    Signed-off-by: Olga Kornievskaia <kolga@xxxxxxxxxx>
    Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
    Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index acb1346da13e9..be570c65ae154 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2708,8 +2708,12 @@ static int _nfs4_proc_open(struct nfs4_opendata *data,
 			return status;
 	}
 	if (!(o_res->f_attr->valid & NFS_ATTR_FATTR)) {
+		struct nfs_fh *fh = &o_res->fh;
+
 		nfs4_sequence_free_slot(&o_res->seq_res);
-		nfs4_proc_getattr(server, &o_res->fh, o_res->f_attr, NULL);
+		if (o_arg->claim == NFS4_OPEN_CLAIM_FH)
+			fh = NFS_FH(d_inode(data->dentry));
+		nfs4_proc_getattr(server, fh, o_res->f_attr, NULL);
 	}
 	return 0;
 }



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux