Patch "iavf: schedule a request immediately after add/delete vlan" has been added to the 6.5-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    iavf: schedule a request immediately after add/delete vlan

to the 6.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iavf-schedule-a-request-immediately-after-add-delete.patch
and it can be found in the queue-6.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 36388c5bd5c72e6f6a8df316988bea393f17e4e0
Author: Petr Oros <poros@xxxxxxxxxx>
Date:   Thu Sep 7 17:02:51 2023 +0200

    iavf: schedule a request immediately after add/delete vlan
    
    [ Upstream commit 5f3d319a248654a805bafc9e7094bcea47dac6c7 ]
    
    When the iavf driver wants to reconfigure the VLAN filters
    (iavf_add_vlan, iavf_del_vlan), it sets a flag in
    aq_required:
      adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
    or:
      adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
    
    This is later processed by the watchdog_task, but it runs periodically
    every 2 seconds, so it can be a long time before it processes the request.
    
    In the worst case, the interface is unable to receive traffic for more
    than 2 seconds for no objective reason.
    
    Fixes: 5eae00c57f5e ("i40evf: main driver core")
    Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
    Co-developed-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
    Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
    Co-developed-by: Ivan Vecera <ivecera@xxxxxxxxxx>
    Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
    Reviewed-by: Ahmed Zaki <ahmed.zaki@xxxxxxxxx>
    Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
    Tested-by: Rafal Romanowski <rafal.romanowski@xxxxxxxxx>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index d76465474049c..8ea5c0825c3c4 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
 		list_add_tail(&f->list, &adapter->vlan_filter_list);
 		f->state = IAVF_VLAN_ADD;
 		adapter->num_vlan_filters++;
-		adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
+		iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
 	}
 
 clearout:
@@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan)
 	f = iavf_find_vlan(adapter, vlan);
 	if (f) {
 		f->state = IAVF_VLAN_REMOVE;
-		adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
+		iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER);
 	}
 
 	spin_unlock_bh(&adapter->mac_vlan_list_lock);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux