This is a note to let you know that I've just added the patch titled
netfilter: nft_flow_offload: fix underflow in flowtable reference counter
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netfilter-nft_flow_offload-fix-underflow-in-flowtable-reference-counter.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From stable-owner@xxxxxxxxxxxxxxx Mon Sep 18 14:08:09 2023
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Mon, 18 Sep 2023 14:06:55 +0200
Subject: netfilter: nft_flow_offload: fix underflow in flowtable reference counter
To: netfilter-devel@xxxxxxxxxxxxxxx
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, sashal@xxxxxxxxxx
Message-ID: <20230918120656.218135-2-pablo@xxxxxxxxxxxxx>
From: wenxu <wenxu@xxxxxxxxx>
commit 8ca79606cdfde2e37ee4f0707b9d1874a6f0eb38 upstream.
The .deactivate and .activate interfaces already deal with the reference
counter. Otherwise, this results in spurious "Device is busy" errors.
Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression")
Signed-off-by: wenxu <wenxu@xxxxxxxxx>
Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/netfilter/nft_flow_offload.c | 3 ---
1 file changed, 3 deletions(-)
--- a/net/netfilter/nft_flow_offload.c
+++ b/net/netfilter/nft_flow_offload.c
@@ -197,9 +197,6 @@ static void nft_flow_offload_activate(co
static void nft_flow_offload_destroy(const struct nft_ctx *ctx,
const struct nft_expr *expr)
{
- struct nft_flow_offload *priv = nft_expr_priv(expr);
-
- priv->flowtable->use--;
nf_ct_netns_put(ctx->net, ctx->family);
}
Patches currently in stable-queue which might be from stable-owner@xxxxxxxxxxxxxxx are
queue-4.19/netfilter-nft_flow_offload-fix-underflow-in-flowtable-reference-counter.patch
queue-4.19/netfilter-nf_tables-missing-nft_trans_prepare_error-in-flowtable-deactivatation.patch
