Patch "veth: Update XDP feature set when bringing up device" has been added to the 6.5-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    veth: Update XDP feature set when bringing up device

to the 6.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     veth-update-xdp-feature-set-when-bringing-up-device.patch
and it can be found in the queue-6.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit cb2497dfac25be4222f66cac7028a0c19115f71a
Author: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
Date:   Mon Sep 11 15:58:25 2023 +0200

    veth: Update XDP feature set when bringing up device
    
    [ Upstream commit 7a6102aa6df0d5d032b4cbc51935d1d4cda17254 ]
    
    There's an early return in veth_set_features() if the device is in a down
    state, which leads to the XDP feature flags not being updated when enabling
    GRO while the device is down. Which in turn leads to XDP_REDIRECT not
    working, because the redirect code now checks the flags.
    
    Fix this by updating the feature flags after bringing the device up.
    
    Before this patch:
    
    NETDEV_XDP_ACT_BASIC:           yes
    NETDEV_XDP_ACT_REDIRECT:        yes
    NETDEV_XDP_ACT_NDO_XMIT:        no
    NETDEV_XDP_ACT_XSK_ZEROCOPY:    no
    NETDEV_XDP_ACT_HW_OFFLOAD:      no
    NETDEV_XDP_ACT_RX_SG:           yes
    NETDEV_XDP_ACT_NDO_XMIT_SG:     no
    
    After this patch:
    
    NETDEV_XDP_ACT_BASIC:           yes
    NETDEV_XDP_ACT_REDIRECT:        yes
    NETDEV_XDP_ACT_NDO_XMIT:        yes
    NETDEV_XDP_ACT_XSK_ZEROCOPY:    no
    NETDEV_XDP_ACT_HW_OFFLOAD:      no
    NETDEV_XDP_ACT_RX_SG:           yes
    NETDEV_XDP_ACT_NDO_XMIT_SG:     yes
    
    Fixes: fccca038f300 ("veth: take into account device reconfiguration for xdp_features flag")
    Fixes: 66c0e13ad236 ("drivers: net: turn on XDP features")
    Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20230911135826.722295-1-toke@xxxxxxxxxx
    Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 2db678c0082a3..fc0d0114d8c27 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1447,6 +1447,8 @@ static int veth_open(struct net_device *dev)
 		netif_carrier_on(peer);
 	}
 
+	veth_set_xdp_features(dev);
+
 	return 0;
 }
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux