Patch "fbdev/ep93xx-fb: Do not assign to struct fb_info.dev" has been added to the 4.14-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

to the 4.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     fbdev-ep93xx-fb-do-not-assign-to-struct-fb_info.dev.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From f90a0e5265b60cdd3c77990e8105f79aa2fac994 Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <tzimmermann@xxxxxxx>
Date: Tue, 13 Jun 2023 13:06:49 +0200
Subject: fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

From: Thomas Zimmermann <tzimmermann@xxxxxxx>

commit f90a0e5265b60cdd3c77990e8105f79aa2fac994 upstream.

Do not assing the Linux device to struct fb_info.dev. The call to
register_framebuffer() initializes the field to the fbdev device.
Drivers should not override its value.

Fixes a bug where the driver incorrectly decreases the hardware
device's reference counter and leaks the fbdev device.

v2:
	* add Fixes tag (Dan)

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Fixes: 88017bda96a5 ("ep93xx video driver")
Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.32+
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-15-tzimmermann@xxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/video/fbdev/ep93xx-fb.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/video/fbdev/ep93xx-fb.c
+++ b/drivers/video/fbdev/ep93xx-fb.c
@@ -478,7 +478,6 @@ static int ep93xxfb_probe(struct platfor
 	if (!info)
 		return -ENOMEM;
 
-	info->dev = &pdev->dev;
 	platform_set_drvdata(pdev, info);
 	fbi = info->par;
 	fbi->mach_info = mach_info;


Patches currently in stable-queue which might be from tzimmermann@xxxxxxx are

queue-4.14/backlight-gpio_backlight-compare-against-struct-fb_info.device.patch
queue-4.14/fbdev-ep93xx-fb-do-not-assign-to-struct-fb_info.dev.patch
queue-4.14/backlight-lv5207lp-compare-against-struct-fb_info.device.patch
queue-4.14/backlight-bd6107-compare-against-struct-fb_info.device.patch
queue-4.14/drm-ast-fix-dram-init-on-ast2200.patch



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux