This is a note to let you know that I've just added the patch titled io_uring: revert "io_uring fix multishot accept ordering" to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: io_uring-revert-io_uring-fix-multishot-accept-ordering.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From stable-owner@xxxxxxxxxxxxxxx Tue Sep 12 15:57:45 2023 From: Pavel Begunkov <asml.silence@xxxxxxxxx> Date: Tue, 12 Sep 2023 14:57:04 +0100 Subject: io_uring: revert "io_uring fix multishot accept ordering" To: stable@xxxxxxxxxxxxxxx Cc: Jens Axboe <axboe@xxxxxxxxx>, asml.silence@xxxxxxxxx, Dylan Yudaken <dylany@xxxxxxxx> Message-ID: <1efad3afea9ba65984ae63ec853f4a29f8e1c0fa.1694486400.git.asml.silence@xxxxxxxxx> From: Pavel Begunkov <asml.silence@xxxxxxxxx> From: Dylan Yudaken <dylany@xxxxxxxx> [ upstream commit 515e26961295bee9da5e26916c27739dca6c10e1 ] This is no longer needed after commit aa1df3a360a0 ("io_uring: fix CQE reordering"), since all reordering is now taken care of. This reverts commit cbd25748545c ("io_uring: fix multishot accept ordering"). Signed-off-by: Dylan Yudaken <dylany@xxxxxxxx> Link: https://lore.kernel.org/r/20221107125236.260132-2-dylany@xxxxxxxx Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- io_uring/net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/io_uring/net.c +++ b/io_uring/net.c @@ -1337,12 +1337,12 @@ retry: return IOU_OK; } - if (ret >= 0 && - io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, false)) + if (ret < 0) + return ret; + if (io_post_aux_cqe(ctx, req->cqe.user_data, ret, IORING_CQE_F_MORE, true)) goto retry; - io_req_set_res(req, ret, 0); - return (issue_flags & IO_URING_F_MULTISHOT) ? IOU_STOP_MULTISHOT : IOU_OK; + return -ECANCELED; } int io_socket_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) Patches currently in stable-queue which might be from stable-owner@xxxxxxxxxxxxxxx are queue-6.1/io_uring-don-t-set-affinity-on-a-dying-sqpoll-thread.patch queue-6.1/io_uring-always-lock-in-io_apoll_task_func.patch queue-6.1/io_uring-revert-io_uring-fix-multishot-accept-ordering.patch queue-6.1/io_uring-net-don-t-overflow-multishot-accept.patch queue-6.1/io_uring-sqpoll-fix-io-wq-affinity-when-ioring_setup_sqpoll-is-used.patch queue-6.1/io_uring-break-out-of-iowq-iopoll-on-teardown.patch