Patch "nvmem: core: Return NULL when no nvmem layout is found" has been added to the 6.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    nvmem: core: Return NULL when no nvmem layout is found

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     nvmem-core-return-null-when-no-nvmem-layout-is-found.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 6149126bb9e2c4bb68254047ccee6bec52b9ffa3
Author: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Date:   Wed Aug 23 14:27:42 2023 +0100

    nvmem: core: Return NULL when no nvmem layout is found
    
    [ Upstream commit 81e1d9a39569d315f747c2af19ce502cd08645ed ]
    
    Currently, of_nvmem_layout_get_container() returns NULL on error, or an
    error pointer if either CONFIG_NVMEM or CONFIG_OF is turned off. We
    should likely avoid this kind of mix for two reasons: to clarify the
    intend and anyway fix the !CONFIG_OF which will likely always if we use
    this helper somewhere else. Let's just return NULL when no layout is
    found, we don't need an error value here.
    
    Link: https://staticthinking.wordpress.com/2022/08/01/mixing-error-pointers-and-null/
    Fixes: 266570f496b9 ("nvmem: core: introduce NVMEM layouts")
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
    Closes: https://lore.kernel.org/r/202308030002.DnSFOrMB-lkp@xxxxxxxxx/
    Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
    Reviewed-by: Michael Walle <michael@xxxxxxxx>
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20230823132744.350618-21-srinivas.kandagatla@xxxxxxxxxx
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
index fa030d93b768e..27373024856dc 100644
--- a/include/linux/nvmem-consumer.h
+++ b/include/linux/nvmem-consumer.h
@@ -256,7 +256,7 @@ static inline struct nvmem_device *of_nvmem_device_get(struct device_node *np,
 static inline struct device_node *
 of_nvmem_layout_get_container(struct nvmem_device *nvmem)
 {
-	return ERR_PTR(-EOPNOTSUPP);
+	return NULL;
 }
 #endif /* CONFIG_NVMEM && CONFIG_OF */
 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux