This is a note to let you know that I've just added the patch titled
firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
firmware-stratix10-svc-fix-an-null-vs-is_err-bug-in-probe.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From dd218433f2b635d97e8fda3eed047151fd528ce4 Mon Sep 17 00:00:00 2001
From: Wang Ming <machel@xxxxxxxx>
Date: Thu, 27 Jul 2023 14:37:50 -0500
Subject: firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe
From: Wang Ming <machel@xxxxxxxx>
commit dd218433f2b635d97e8fda3eed047151fd528ce4 upstream.
The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.
Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Wang Ming <machel@xxxxxxxx>
Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230727193750.983795-1-dinguyen@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/firmware/stratix10-svc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -616,7 +616,7 @@ svc_create_memory_pool(struct platform_d
paddr = begin;
size = end - begin;
va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
- if (!va) {
+ if (IS_ERR(va)) {
dev_err(dev, "fail to remap shared memory\n");
return ERR_PTR(-EINVAL);
}
Patches currently in stable-queue which might be from machel@xxxxxxxx are
queue-5.4/firmware-stratix10-svc-fix-an-null-vs-is_err-bug-in-probe.patch
