This is a note to let you know that I've just added the patch titled
netfilter: nf_queue: fix socket leak
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netfilter-nf_queue-fix-socket-leak.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From vbrahmajosyula@xxxxxxxxxx Sun Aug 27 11:12:19 2023
From: Vamsi Krishna Brahmajosyula <vbrahmajosyula@xxxxxxxxxx>
Date: Sat, 26 Aug 2023 06:50:56 +0000
Subject: netfilter: nf_queue: fix socket leak
To: stable@xxxxxxxxxxxxxxx
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxx, pablo@xxxxxxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, fw@xxxxxxxxx, davem@xxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, amakhalov@xxxxxxxxxx, srinidhir@xxxxxxxxxx, vsirnapalli@xxxxxxxxxx, akaher@xxxxxxxxxx, tkundu@xxxxxxxxxx, keerthanak@xxxxxxxxxx, psinghchauha@xxxxxxxxxx, Vimal Agrawal <vimal.agrawal@xxxxxxxxxx>
Message-ID: <20230826065055.4691-1-vbrahmajosyula@xxxxxxxxxx>
From: Vamsi Krishna Brahmajosyula <vbrahmajosyula@xxxxxxxxxx>
Removal of the sock_hold got lost when backporting commit c3873070247d
("netfilter: nf_queue: fix possible use-after-free") to 4.19
Fixes: 34dc4a6a7f26 ("netfilter: nf_queue: fix possible use-after-free") in 4.19
Fixed in 4.14 with
https://lore.kernel.org/all/20221024112958.115275475@xxxxxxxxxxxxxxxxxxx/
Signed-off-by: Vimal Agrawal <vimal.agrawal@xxxxxxxxxx>
Reviewed-by: Florian Westphal <fw@xxxxxxxxx>
[vbrahmajosyula: The fix to the backport was missed in 4.19]
Signed-off-by: Vamsi Krishna Brahmajosyula <vbrahmajosyula@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
net/netfilter/nf_queue.c | 2 --
1 file changed, 2 deletions(-)
--- a/net/netfilter/nf_queue.c
+++ b/net/netfilter/nf_queue.c
@@ -93,8 +93,6 @@ bool nf_queue_entry_get_refs(struct nf_q
dev_hold(state->in);
if (state->out)
dev_hold(state->out);
- if (state->sk)
- sock_hold(state->sk);
#if IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
if (entry->skb->nf_bridge) {
struct net_device *physdev;
Patches currently in stable-queue which might be from vbrahmajosyula@xxxxxxxxxx are
queue-4.19/netfilter-nf_queue-fix-socket-leak.patch
