Patch "ice: fix receive buffer size miscalculation" has been added to the 5.15-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ice: fix receive buffer size miscalculation

to the 5.15-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ice-fix-receive-buffer-size-miscalculation.patch
and it can be found in the queue-5.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5be47c57a161e8a36a173976283e7749fa570afd
Author: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
Date:   Thu Aug 10 16:51:10 2023 -0700

    ice: fix receive buffer size miscalculation
    
    [ Upstream commit 10083aef784031fa9f06c19a1b182e6fad5338d9 ]
    
    The driver is misconfiguring the hardware for some values of MTU such that
    it could use multiple descriptors to receive a packet when it could have
    simply used one.
    
    Change the driver to use a round-up instead of the result of a shift, as
    the shift can truncate the lower bits of the size, and result in the
    problem noted above. It also aligns this driver with similar code in i40e.
    
    The insidiousness of this problem is that everything works with the wrong
    size, it's just not working as well as it could, as some MTU sizes end up
    using two or more descriptors, and there is no way to tell that is
    happening without looking at ice_trace or a bus analyzer.
    
    Fixes: efc2214b6047 ("ice: Add support for XDP")
    Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
    Signed-off-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
    Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
    Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@xxxxxxxxx> (A Contingent worker at Intel)
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c
index 533a953f15acb..09525dbeccfec 100644
--- a/drivers/net/ethernet/intel/ice/ice_base.c
+++ b/drivers/net/ethernet/intel/ice/ice_base.c
@@ -359,7 +359,8 @@ static int ice_setup_rx_ctx(struct ice_ring *ring)
 	/* Receive Packet Data Buffer Size.
 	 * The Packet Data Buffer Size is defined in 128 byte units.
 	 */
-	rlan_ctx.dbuf = ring->rx_buf_len >> ICE_RLAN_CTX_DBUF_S;
+	rlan_ctx.dbuf = DIV_ROUND_UP(ring->rx_buf_len,
+				     BIT_ULL(ICE_RLAN_CTX_DBUF_S));
 
 	/* use 32 byte descriptors */
 	rlan_ctx.dsize = 1;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux