This is a note to let you know that I've just added the patch titled x86/alternative: Make custom return thunk unconditional to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: x86-alternative-make-custom-return-thunk-unconditional.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 095b8303f3835c68ac4a8b6d754ca1c3b6230711 Mon Sep 17 00:00:00 2001 From: Peter Zijlstra <peterz@xxxxxxxxxxxxx> Date: Mon, 14 Aug 2023 13:44:30 +0200 Subject: x86/alternative: Make custom return thunk unconditional From: Peter Zijlstra <peterz@xxxxxxxxxxxxx> commit 095b8303f3835c68ac4a8b6d754ca1c3b6230711 upstream. There is infrastructure to rewrite return thunks to point to any random thunk one desires, unwrap that from CALL_THUNKS, which up to now was the sole user of that. [ bp: Make the thunks visible on 32-bit and add ifdeffery for the 32-bit builds. ] Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx> Link: https://lore.kernel.org/r/20230814121148.775293785@xxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- arch/x86/include/asm/nospec-branch.h | 5 +++++ arch/x86/kernel/cpu/bugs.c | 2 ++ 2 files changed, 7 insertions(+) --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h @@ -195,7 +195,12 @@ _ASM_PTR " 999b\n\t" \ ".popsection\n\t" +#ifdef CONFIG_RETHUNK extern void __x86_return_thunk(void); +#else +static inline void __x86_return_thunk(void) {} +#endif + extern void zen_untrain_ret(void); extern void srso_untrain_ret(void); extern void srso_untrain_ret_alias(void); --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -61,6 +61,8 @@ EXPORT_SYMBOL_GPL(x86_pred_cmd); static DEFINE_MUTEX(spec_ctrl_mutex); +void (*x86_return_thunk)(void) __ro_after_init = &__x86_return_thunk; + /* Update SPEC_CTRL MSR and its cached copy unconditionally */ static void update_spec_ctrl(u64 val) { Patches currently in stable-queue which might be from peterz@xxxxxxxxxxxxx are queue-5.10/x86-cpu-fix-up-srso_safe_ret-and-__x86_return_thunk.patch queue-5.10/x86-static_call-fix-__static_call_fixup.patch queue-5.10/x86-cpu-cleanup-the-untrain-mess.patch queue-5.10/iopoll-call-cpu_relax-in-busy-loops.patch queue-5.10/objtool-x86-fixup-frame-pointer-vs-rethunk.patch queue-5.10/x86-ibt-add-annotate_noendbr.patch queue-5.10/x86-retpoline-kprobes-fix-position-of-thunk-sections-with-config_lto_clang.patch queue-5.10/x86-cpu-rename-srso_-.-_alias-to-srso_alias_-1.patch queue-5.10/x86-alternative-make-custom-return-thunk-unconditional.patch queue-5.10/x86-cpu-rename-original-retbleed-methods.patch queue-5.10/x86-cpu-clean-up-srso-return-thunk-mess.patch queue-5.10/x86-cpu-fix-__x86_return_thunk-symbol-type.patch