This is a note to let you know that I've just added the patch titled
vdpa: Add features attr to vdpa_nl_policy for nlattr length check
to the 6.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
vdpa-add-features-attr-to-vdpa_nl_policy-for-nlattr-length-check.patch
and it can be found in the queue-6.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 79c8651587504ba263d2fd67fd4406240fb21f69 Mon Sep 17 00:00:00 2001
From: Lin Ma <linma@xxxxxxxxxx>
Date: Thu, 27 Jul 2023 20:57:48 +0300
Subject: vdpa: Add features attr to vdpa_nl_policy for nlattr length check
From: Lin Ma <linma@xxxxxxxxxx>
commit 79c8651587504ba263d2fd67fd4406240fb21f69 upstream.
The vdpa_nl_policy structure is used to validate the nlattr when parsing
the incoming nlmsg. It will ensure the attribute being described produces
a valid nlattr pointer in info->attrs before entering into each handler
in vdpa_nl_ops.
That is to say, the missing part in vdpa_nl_policy may lead to illegal
nlattr after parsing, which could lead to OOB read just like CVE-2023-3773.
This patch adds the missing nla_policy for vdpa features attr to avoid
such bugs.
Fixes: 90fea5a800c3 ("vdpa: device feature provisioning")
Signed-off-by: Lin Ma <linma@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Message-Id: <20230727175757.73988-3-dtatulea@xxxxxxxxxx>
Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/vdpa/vdpa.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -1249,6 +1249,7 @@ static const struct nla_policy vdpa_nl_p
[VDPA_ATTR_DEV_NET_CFG_MACADDR] = NLA_POLICY_ETH_ADDR,
/* virtio spec 1.1 section 5.1.4.1 for valid MTU range */
[VDPA_ATTR_DEV_NET_CFG_MTU] = NLA_POLICY_MIN(NLA_U16, 68),
+ [VDPA_ATTR_DEV_FEATURES] = { .type = NLA_U64 },
};
static const struct genl_ops vdpa_nl_ops[] = {
Patches currently in stable-queue which might be from linma@xxxxxxxxxx are
queue-6.4/vdpa-add-queue-index-attr-to-vdpa_nl_policy-for-nlattr-length-check.patch
queue-6.4/vdpa-add-features-attr-to-vdpa_nl_policy-for-nlattr-length-check.patch
queue-6.4/vdpa-add-max-vqp-attr-to-vdpa_nl_policy-for-nlattr-length-check.patch
