This is a note to let you know that I've just added the patch titled
scsi: core: Fix possible memory leak if device_add() fails
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-core-fix-possible-memory-leak-if-device_add-fails.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 04b5b5cb0136ce970333a9c6cec7e46adba1ea3a Mon Sep 17 00:00:00 2001
From: Zhu Wang <wangzhu9@xxxxxxxxxx>
Date: Thu, 3 Aug 2023 10:02:30 +0800
Subject: scsi: core: Fix possible memory leak if device_add() fails
From: Zhu Wang <wangzhu9@xxxxxxxxxx>
commit 04b5b5cb0136ce970333a9c6cec7e46adba1ea3a upstream.
If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to decrease the reference count in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().
Fixes: ee959b00c335 ("SCSI: convert struct class_device to struct device")
Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230803020230.226903-1-wangzhu9@xxxxxxxxxx
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/raid_class.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/scsi/raid_class.c
+++ b/drivers/scsi/raid_class.c
@@ -248,6 +248,7 @@ int raid_component_add(struct raid_templ
return 0;
err_out:
+ put_device(&rc->dev);
list_del(&rc->node);
rd->component_count--;
put_device(component_dev);
Patches currently in stable-queue which might be from wangzhu9@xxxxxxxxxx are
queue-4.14/scsi-snic-fix-possible-memory-leak-if-device_add-fails.patch
queue-4.14/scsi-core-fix-possible-memory-leak-if-device_add-fails.patch
