This is a note to let you know that I've just added the patch titled
scsi: qla2xxx: Fix end of loop test
to the 6.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-qla2xxx-fix-end-of-loop-test.patch
and it can be found in the queue-6.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 339020091e246e708c1381acf74c5f8e3fe4d2b5 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 22 May 2023 14:09:17 +0300
Subject: scsi: qla2xxx: Fix end of loop test
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
commit 339020091e246e708c1381acf74c5f8e3fe4d2b5 upstream.
This loop will exit successfully when "found" is false or in the failure
case it times out with "wait_iter" set to -1. The test for timeouts is
impossible as is.
Fixes: b843adde8d49 ("scsi: qla2xxx: Fix mem access after free")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Link: https://lore.kernel.org/r/cea5a62f-b873-4347-8f8e-c67527ced8d2@kili.mountain
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1409,7 +1409,7 @@ __qla2x00_eh_wait_for_pending_commands(s
break;
}
- if (!wait_iter && found)
+ if (wait_iter == -1)
status = QLA_FUNCTION_FAILED;
return status;
Patches currently in stable-queue which might be from dan.carpenter@xxxxxxxxxx are
queue-6.4/tracing-probes-fix-to-avoid-double-count-of-the-string-length-on-the-array.patch
queue-6.4/net-dsa-ocelot-unlock-on-error-in-vsc9959_qos_port_tas_set.patch
queue-6.4/netdevsim-fix-uninitialized-data-in-nsim_dev_trap_fa.patch
queue-6.4/kernel-trace-fix-cleanup-logic-of-enable_trace_eprob.patch
queue-6.4/scsi-qla2xxx-fix-end-of-loop-test.patch
queue-6.4/serial-atmel-don-t-enable-irqs-prematurely.patch
queue-6.4/scsi-qla2xxx-fix-error-code-in-qla2x00_start_sp.patch
queue-6.4/tracing-probes-fix-not-to-count-error-code-to-total-length.patch
