This is a note to let you know that I've just added the patch titled
tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tty-serial-samsung_tty-fix-a-memory-leak-in-s3c24xx_serial_getclk-in-case-of-error.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From a9c09546e903f1068acfa38e1ee18bded7114b37 Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Sat, 10 Jun 2023 17:59:25 +0200
Subject: tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error
From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
commit a9c09546e903f1068acfa38e1ee18bded7114b37 upstream.
If clk_get_rate() fails, the clk that has just been allocated needs to be
freed.
Cc: <stable@xxxxxxxxxxxxxxx> # v3.3+
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
Message-ID: <e4baf6039368f52e5a5453982ddcb9a330fc689e.1686412569.git.christophe.jaillet@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/tty/serial/samsung.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1199,8 +1199,12 @@ static unsigned int s3c24xx_serial_getcl
continue;
rate = clk_get_rate(clk);
- if (!rate)
+ if (!rate) {
+ dev_err(ourport->port.dev,
+ "Failed to get clock rate for %s.\n", clkname);
+ clk_put(clk);
continue;
+ }
if (ourport->info->has_divslot) {
unsigned long div = rate / req_baud;
Patches currently in stable-queue which might be from christophe.jaillet@xxxxxxxxxx are
queue-5.4/wifi-orinoco-fix-an-error-handling-path-in-orinoco_c.patch
queue-5.4/wifi-atmel-fix-an-error-handling-path-in-atmel_probe.patch
queue-5.4/rtc-st-lpc-release-some-resources-in-st_rtc_probe-in.patch
queue-5.4/usb-dwc3-qcom-release-the-correct-resources-in-dwc3_.patch
queue-5.4/wifi-wl3501_cs-fix-an-error-handling-path-in-wl3501_.patch
queue-5.4/mfd-stmpe-only-disable-the-regulators-if-they-are-en.patch
queue-5.4/fbdev-omapfb-lcd_mipid-fix-an-error-handling-path-in.patch
queue-5.4/wifi-ray_cs-fix-an-error-handling-path-in-ray_probe.patch
queue-5.4/wifi-mwifiex-fix-the-size-of-a-memory-allocation-in-.patch
queue-5.4/tty-serial-samsung_tty-fix-a-memory-leak-in-s3c24xx_serial_getclk-when-iterating-clk.patch
queue-5.4/firmware-stratix10-svc-fix-a-potential-resource-leak-in-svc_create_memory_pool.patch
queue-5.4/wifi-orinoco-fix-an-error-handling-path-in-spectrum_.patch
queue-5.4/tty-serial-samsung_tty-fix-a-memory-leak-in-s3c24xx_serial_getclk-in-case-of-error.patch
