This is a note to let you know that I've just added the patch titled
spi: spi-fsl-spi: remove always-true conditional in fsl_spi_do_one_msg
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
spi-spi-fsl-spi-remove-always-true-conditional-in-fsl_spi_do_one_msg.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 24c363623361b430fb79459ca922e816e6f48603 Mon Sep 17 00:00:00 2001
From: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
Date: Wed, 27 Mar 2019 14:30:50 +0000
Subject: spi: spi-fsl-spi: remove always-true conditional in fsl_spi_do_one_msg
From: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
commit 24c363623361b430fb79459ca922e816e6f48603 upstream.
__spi_validate() in the generic SPI code sets ->speed_hz and
->bits_per_word to non-zero values, so this condition is always true.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/spi/spi-fsl-spi.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
--- a/drivers/spi/spi-fsl-spi.c
+++ b/drivers/spi/spi-fsl-spi.c
@@ -387,12 +387,10 @@ static int fsl_spi_do_one_msg(struct spi
cs_change = 1;
status = -EINVAL;
list_for_each_entry(t, &m->transfers, transfer_list) {
- if (t->bits_per_word || t->speed_hz) {
- if (cs_change)
- status = fsl_spi_setup_transfer(spi, t);
- if (status < 0)
- break;
- }
+ if (cs_change)
+ status = fsl_spi_setup_transfer(spi, t);
+ if (status < 0)
+ break;
if (cs_change) {
fsl_spi_chipselect(spi, BITBANG_CS_ACTIVE);
Patches currently in stable-queue which might be from rasmus.villemoes@xxxxxxxxx are
queue-4.14/spi-spi-fsl-spi-relax-message-sanity-checking-a-little.patch
queue-4.14/spi-spi-fsl-spi-remove-always-true-conditional-in-fsl_spi_do_one_msg.patch
queue-4.14/spi-spi-fsl-spi-allow-changing-bits_per_word-while-cs-is-still-active.patch
