This is a note to let you know that I've just added the patch titled mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mmc-core-disable-trim-on-micron-mtfc4gacajcn-1m.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From dbfbddcddcebc9ce8a08757708d4e4a99d238e44 Mon Sep 17 00:00:00 2001 From: Robert Marko <robimarko@xxxxxxxxx> Date: Tue, 30 May 2023 23:32:59 +0200 Subject: mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M From: Robert Marko <robimarko@xxxxxxxxx> commit dbfbddcddcebc9ce8a08757708d4e4a99d238e44 upstream. It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko <robimarko@xxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx Link: https://lore.kernel.org/r/20230530213259.1776512-1-robimarko@xxxxxxxxx Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -107,6 +107,13 @@ static const struct mmc_fixup __maybe_un MMC_QUIRK_TRIM_BROKEN), /* + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to + * support being used to offload WRITE_ZEROES. + */ + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), + + /* * Some SD cards reports discard support while they don't */ MMC_FIXUP(CID_NAME_ANY, CID_MANFID_SANDISK_SD, 0x5344, add_quirk_sd, Patches currently in stable-queue which might be from robimarko@xxxxxxxxx are queue-5.15/mmc-core-disable-trim-on-kingston-emmc04g-m627.patch queue-5.15/clk-qcom-ipq6018-fix-networking-resets.patch queue-5.15/mmc-core-disable-trim-on-micron-mtfc4gacajcn-1m.patch queue-5.15/clk-qcom-reset-support-resetting-multiple-bits.patch