Patch "usb: dwc2: platform: Improve error reporting for problems during .remove()" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    usb: dwc2: platform: Improve error reporting for problems during .remove()

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-dwc2-platform-improve-error-reporting-for-proble.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit b436bd52a3e8dd51370e8220dc1aac03fe21e7ca
Author: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Date:   Mon Oct 17 21:59:14 2022 +0200

    usb: dwc2: platform: Improve error reporting for problems during .remove()
    
    [ Upstream commit 55f223b8b408cbfd85fb1c5b74ab85ccab319a69 ]
    
    Returning an error value in a platform driver's remove callback results in
    a generic error message being emitted by the driver core, but otherwise it
    doesn't make a difference. The device goes away anyhow.
    
    For each case where ret is non-zero the driver already emits an error
    message, so suppress the generic error message by returning zero
    unconditionally. (Side note: The return value handling was unreliable
    anyhow as the value returned by dwc2_exit_hibernation() was overwritten
    anyhow if hsotg->in_ppd was non-zero.)
    
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
    Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/20221017195914.1426297-1-u.kleine-koenig@xxxxxxxxxxxxxx
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    Stable-dep-of: ada050c69108 ("usb: dwc2: Fix some error handling paths")
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 0c02ef7628fd5..d1589ba7d322d 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -309,7 +309,7 @@ static int dwc2_driver_remove(struct platform_device *dev)
 	reset_control_assert(hsotg->reset);
 	reset_control_assert(hsotg->reset_ecc);
 
-	return ret;
+	return 0;
 }
 
 /**



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux