Patch "mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init" has been added to the 6.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mlxsw-minimal-fix-potential-memory-leak-in-mlxsw_m_l.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 250ee84c4275bb563a0558438e41d7be71238c8c
Author: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>
Date:   Fri Jun 30 09:26:47 2023 +0800

    mlxsw: minimal: fix potential memory leak in mlxsw_m_linecards_init
    
    [ Upstream commit 08fc75735fda3be97194bfbf3c899c87abb3d0fe ]
    
    The line cards array is not freed in the error path of
    mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
    freeing the array in the error path, thereby making the error path
    identical to mlxsw_m_linecards_fini().
    
    Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
    Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>
    Reviewed-by: Petr Machata <petrm@xxxxxxxxxx>
    Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20230630012647.1078002-1-shaozhengchao@xxxxxxxxxx
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
index 6b56eadd736e5..6b98c3287b497 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
@@ -417,6 +417,7 @@ static int mlxsw_m_linecards_init(struct mlxsw_m *mlxsw_m)
 err_kmalloc_array:
 	for (i--; i >= 0; i--)
 		kfree(mlxsw_m->line_cards[i]);
+	kfree(mlxsw_m->line_cards);
 err_kcalloc:
 	kfree(mlxsw_m->ports);
 	return err;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux