Patch "platform/x86: thinkpad_acpi: Fix lkp-tests warnings for platform profiles" has been added to the 6.3-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    platform/x86: thinkpad_acpi: Fix lkp-tests warnings for platform profiles

to the 6.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     platform-x86-thinkpad_acpi-fix-lkp-tests-warnings-fo.patch
and it can be found in the queue-6.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 8ddd578b0bdc061ee784e08e21cbfcf3d4080433
Author: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
Date:   Tue Jun 6 11:18:04 2023 -0400

    platform/x86: thinkpad_acpi: Fix lkp-tests warnings for platform profiles
    
    [ Upstream commit f999e23ce66c1555d7b653fba171a88ecee53704 ]
    
    Fix issues identified in dytc_profile_refresh identified by lkp-tests.
    drivers/platform/x86/thinkpad_acpi.c:10538
            dytc_profile_refresh() error: uninitialized symbol 'funcmode'.
    drivers/platform/x86/thinkpad_acpi.c:10531
            dytc_profile_refresh() error: uninitialized symbol 'output'.
    drivers/platform/x86/thinkpad_acpi.c:10537
            dytc_profile_refresh() error: uninitialized symbol 'output'.
    
    These issues should not lead to real problems in the field as the refresh
    function should only be called if MMC or PSC mode enabled. But good to fix.
    
    Thanks to Dan Carpenter and the lkp-tests project for flagging these.
    
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Reported-by: Dan Carpenter <error27@xxxxxxxxx>
    Closes: https://lore.kernel.org/r/202306011202.1hbgLRD4-lkp@xxxxxxxxx/
    Fixes: 1bc5d819f0b9 ("platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms")
    Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
    Link: https://lore.kernel.org/r/20230606151804.8819-1-mpearson-lenovo@xxxxxxxxx
    Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
    Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index e40cbe81b12c1..97c6ec12d0829 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -10524,8 +10524,8 @@ static int dytc_profile_set(struct platform_profile_handler *pprof,
 static void dytc_profile_refresh(void)
 {
 	enum platform_profile_option profile;
-	int output, err = 0;
-	int perfmode, funcmode;
+	int output = 0, err = 0;
+	int perfmode, funcmode = 0;
 
 	mutex_lock(&dytc_mutex);
 	if (dytc_capabilities & BIT(DYTC_FC_MMC)) {
@@ -10538,6 +10538,8 @@ static void dytc_profile_refresh(void)
 		err = dytc_command(DYTC_CMD_GET, &output);
 		/* Check if we are PSC mode, or have AMT enabled */
 		funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF;
+	} else { /* Unknown profile mode */
+		err = -ENODEV;
 	}
 	mutex_unlock(&dytc_mutex);
 	if (err)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux