Patch "PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain()" has been added to the 6.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain()

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pci-vmd-fix-uninitialized-variable-usage-in-vmd_enab.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit e4950a7b8150ef59786359f18647391fc69c0d8b
Author: Xinghui Li <korantli@xxxxxxxxxxx>
Date:   Thu Apr 20 17:43:31 2023 +0800

    PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain()
    
    [ Upstream commit 0c0206dc4f5ba2d18b15e24d2047487d6f73916b ]
    
    The ret variable in the vmd_enable_domain() function was used
    uninitialized when printing a warning message upon failure of
    the pci_reset_bus() function.
    
    Thus, fix the issue by assigning ret with the value returned from
    pci_reset_bus() before referencing it in the warning message.
    
    This was detected by Smatch:
    
      drivers/pci/controller/vmd.c:931 vmd_enable_domain() error: uninitialized symbol 'ret'.
    
    [kwilczynski: drop the second patch from the series, add missing reported
    by tag, commit log]
    Fixes: 0a584655ef89 ("PCI: vmd: Fix secondary bus reset for Intel bridges")
    Link: https://lore.kernel.org/all/202305270219.B96IiIfv-lkp@xxxxxxxxx
    Link: https://lore.kernel.org/linux-pci/20230420094332.1507900-2-korantwork@xxxxxxxxx
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Reported-by: Dan Carpenter <error27@xxxxxxxxx>
    Signed-off-by: Xinghui Li <korantli@xxxxxxxxxxx>
    Signed-off-by: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx>
    Reviewed-by: Nirmal Patel <nirmal.patel@xxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 30ec18283aaf4..e718a816d4814 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -927,7 +927,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features)
 		if (!list_empty(&child->devices)) {
 			dev = list_first_entry(&child->devices,
 					       struct pci_dev, bus_list);
-			if (pci_reset_bus(dev))
+			ret = pci_reset_bus(dev);
+			if (ret)
 				pci_warn(dev, "can't reset device: %d\n", ret);
 
 			break;



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux