Patch "perf tests task_analyzer: Fix bad substitution ${$1}" has been added to the 6.4-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    perf tests task_analyzer: Fix bad substitution ${$1}

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     perf-tests-task_analyzer-fix-bad-substitution-1.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5e8eef0856efac32e1bb6589b7f7ed4aebdcf642
Author: Aditya Gupta <adityag@xxxxxxxxxxxxx>
Date:   Tue Jun 13 22:11:43 2023 +0530

    perf tests task_analyzer: Fix bad substitution ${$1}
    
    [ Upstream commit 5c4396efb53ef07d046a2e9456b240880e0c3076 ]
    
    ${$1} gives bad substitution error on sh, bash, and zsh. This seems like
    a typo, and this patch modifies it to $1, since that is what it's usage
    looks like from wherever `check_exec_0` is called.
    
    This issue due to ${$1} caused all function calls to give error in
    `find_str_or_fail` line, and so no test runs completely. But
    'perf test "perf script task-analyzer tests"' wrongly reports
    that tests passed with the status OK, which is wrong considering
    the tests didn't even run completely
    
    Fixes: e8478b84d6ba9ccf ("perf test: add new task-analyzer tests")
    Signed-off-by: Aditya Gupta <adityag@xxxxxxxxxxxxx>
    Signed-off-by: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>
    Signed-off-by: Kajol Jain <kjain@xxxxxxxxxxxxx>
    Cc: Disha Goel <disgoel@xxxxxxxxxxxxxxxxxx>
    Cc: Hagen Paul Pfeifer <hagen@xxxxxxxx>
    Cc: Ian Rogers <irogers@xxxxxxxxxx>
    Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
    Cc: John Garry <john.g.garry@xxxxxxxxxx>
    Cc: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>
    Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
    Cc: Petar Gligoric <petar.gligoric@xxxxxxxxxxxxxxxxx>
    Cc: Ravi Bangoria <ravi.bangoria@xxxxxxx>
    Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
    Link: https://lore.kernel.org/r/20230613164145.50488-16-atrajeev@xxxxxxxxxxxxxxxxxx
    Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/perf/tests/shell/test_task_analyzer.sh b/tools/perf/tests/shell/test_task_analyzer.sh
index a98e4ab66040e..6b3343234a6b2 100755
--- a/tools/perf/tests/shell/test_task_analyzer.sh
+++ b/tools/perf/tests/shell/test_task_analyzer.sh
@@ -31,7 +31,7 @@ report() {
 
 check_exec_0() {
 	if [ $? != 0 ]; then
-		report 1 "invokation of ${$1} command failed"
+		report 1 "invocation of $1 command failed"
 	fi
 }