Patch "pinctrl:sunplus: Add check for kmalloc" has been added to the 6.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    pinctrl:sunplus: Add check for kmalloc

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pinctrl-sunplus-add-check-for-kmalloc.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit d515b3bd11ab67c34bd6e187f2da8dbd78df3154
Author: Wells Lu <wellslutw@xxxxxxxxx>
Date:   Sun May 28 20:34:37 2023 +0800

    pinctrl:sunplus: Add check for kmalloc
    
    [ Upstream commit 73f8ce7f961afcb3be49352efeb7c26cc1c00cc4 ]
    
    Fix Smatch static checker warning:
    potential null dereference 'configs'. (kmalloc returns null)
    
    Changes in v2:
    1. Add free allocated memory before returned -ENOMEM.
    2. Add call of_node_put() before returned -ENOMEM.
    
    Fixes: aa74c44be19c ("pinctrl: Add driver for Sunplus SP7021")
    Signed-off-by: Wells Lu <wellslutw@xxxxxxxxx>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
    Link: https://lore.kernel.org/r/1685277277-12209-1-git-send-email-wellslutw@xxxxxxxxx
    [Rebased on the patch from Lu Hongfei]
    Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pinctrl/sunplus/sppctl.c b/drivers/pinctrl/sunplus/sppctl.c
index e91ce5b5d5598..150996949ede7 100644
--- a/drivers/pinctrl/sunplus/sppctl.c
+++ b/drivers/pinctrl/sunplus/sppctl.c
@@ -971,8 +971,7 @@ static int sppctl_dt_node_to_map(struct pinctrl_dev *pctldev, struct device_node
 
 sppctl_map_err:
 	for (i = 0; i < (*num_maps); i++)
-		if (((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN) &&
-		    (*map)[i].data.configs.configs)
+		if ((*map)[i].type == PIN_MAP_TYPE_CONFIGS_PIN)
 			kfree((*map)[i].data.configs.configs);
 	kfree(*map);
 	of_node_put(parent);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux