Patch "selftests/bpf: Do not use sign-file as testcase" has been added to the 6.4-stable tree

[Sasha Levin <sashal@xxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    selftests/bpf: Do not use sign-file as testcase

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     selftests-bpf-do-not-use-sign-file-as-testcase.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit d55ec8be908a9c9fce45eb1ce26af32f202991ba
Author: Alexey Gladkov <legion@xxxxxxxxxx>
Date:   Wed May 17 11:49:46 2023 +0200

    selftests/bpf: Do not use sign-file as testcase
    
    [ Upstream commit f04a32b2c5b539e3c097cb5c7c1df12a8f4a0cf0 ]
    
    The sign-file utility (from scripts/) is used in prog_tests/verify_pkcs7_sig.c,
    but the utility should not be called as a test. Executing this utility produces
    the following error:
    
      selftests: /linux/tools/testing/selftests/bpf: urandom_read
      ok 16 selftests: /linux/tools/testing/selftests/bpf: urandom_read
    
      selftests: /linux/tools/testing/selftests/bpf: sign-file
      not ok 17 selftests: /linux/tools/testing/selftests/bpf: sign-file # exit=2
    
    Also, urandom_read is mistakenly used as a test. It does not lead to an error,
    but should be moved over to TEST_GEN_FILES as well. The empty TEST_CUSTOM_PROGS
    can then be removed.
    
    Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
    Signed-off-by: Alexey Gladkov <legion@xxxxxxxxxx>
    Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
    Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
    Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
    Link: https://lore.kernel.org/bpf/ZEuWFk3QyML9y5QQ@xxxxxxxxxxx
    Link: https://lore.kernel.org/bpf/88e3ab23029d726a2703adcf6af8356f7a2d3483.1684316821.git.legion@xxxxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 28d2c77262bed..538df8fb8c42b 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -88,8 +88,7 @@ TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \
 	xskxceiver xdp_redirect_multi xdp_synproxy veristat xdp_hw_metadata \
 	xdp_features
 
-TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read $(OUTPUT)/sign-file
-TEST_GEN_FILES += liburandom_read.so
+TEST_GEN_FILES += liburandom_read.so urandom_read sign-file
 
 # Emit succinct information message describing current building step
 # $1 - generic step name (e.g., CC, LINK, etc);