Patch "irqchip/stm32-exti: Fix warning on initialized field overwritten" has been added to the 6.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    irqchip/stm32-exti: Fix warning on initialized field overwritten

to the 6.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     irqchip-stm32-exti-fix-warning-on-initialized-field-.patch
and it can be found in the queue-6.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5f164428edf8fb98eb0999a5c698cf56899f10d6
Author: Antonio Borneo <antonio.borneo@xxxxxxxxxxx>
Date:   Thu Jun 1 17:56:14 2023 +0200

    irqchip/stm32-exti: Fix warning on initialized field overwritten
    
    [ Upstream commit 48f31e496488a25f443c0df52464da446fb1d10c ]
    
    While compiling with W=1, both gcc and clang complain about a
    tricky way to initialize an array by filling it with a non-zero
    value and then overrride some of the array elements.
    In this case the override is intentional, so just disable the
    specific warning for only this part of the code.
    
    Note: the flag "-Woverride-init" is recognized by both compilers,
    but the warning msg from clang reports "-Winitializer-overrides".
    The doc of clang clarifies that the two flags are synonyms, so use
    here only the flag name common on both compilers.
    
    Signed-off-by: Antonio Borneo <antonio.borneo@xxxxxxxxxxx>
    Fixes: c297493336b7 ("irqchip/stm32-exti: Simplify irq description table")
    Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20230601155614.34490-1-antonio.borneo@xxxxxxxxxxx
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index 6a3f7498ea8ea..8bbb2b114636c 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -173,6 +173,16 @@ static struct irq_chip stm32_exti_h_chip_direct;
 #define EXTI_INVALID_IRQ       U8_MAX
 #define STM32MP1_DESC_IRQ_SIZE (ARRAY_SIZE(stm32mp1_exti_banks) * IRQS_PER_BANK)
 
+/*
+ * Use some intentionally tricky logic here to initialize the whole array to
+ * EXTI_INVALID_IRQ, but then override certain fields, requiring us to indicate
+ * that we "know" that there are overrides in this structure, and we'll need to
+ * disable that warning from W=1 builds.
+ */
+__diag_push();
+__diag_ignore_all("-Woverride-init",
+		  "logic to initialize all and then override some is OK");
+
 static const u8 stm32mp1_desc_irq[] = {
 	/* default value */
 	[0 ... (STM32MP1_DESC_IRQ_SIZE - 1)] = EXTI_INVALID_IRQ,
@@ -266,6 +276,8 @@ static const u8 stm32mp13_desc_irq[] = {
 	[70] = 98,
 };
 
+__diag_pop();
+
 static const struct stm32_exti_drv_data stm32mp1_drv_data = {
 	.exti_banks = stm32mp1_exti_banks,
 	.bank_nr = ARRAY_SIZE(stm32mp1_exti_banks),



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux