This is a note to let you know that I've just added the patch titled selftests: mptcp: connect: skip transp tests if not supported to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: selftests-mptcp-connect-skip-transp-tests-if-not-supported.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 07bf49401909264a38fa3427c3cce43e8304436a Mon Sep 17 00:00:00 2001 From: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> Date: Thu, 8 Jun 2023 18:38:44 +0200 Subject: selftests: mptcp: connect: skip transp tests if not supported From: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> commit 07bf49401909264a38fa3427c3cce43e8304436a upstream. Selftests are supposed to run on any kernels, including the old ones not supporting all MPTCP features. One of them is the support of IP(V6)_TRANSPARENT socket option with MPTCP connections introduced by commit c9406a23c116 ("mptcp: sockopt: add SOL_IP freebind & transparent options"). It is possible to look for "__ip_sock_set_tos" in kallsyms because IP(V6)_TRANSPARENT socket option support has been added after TOS support which came with the required infrastructure in MPTCP sockopt code. To support TOS, the following function has been exported (T). Not great but better than checking for a specific kernel version. Link: https://github.com/multipath-tcp/mptcp_net-next/issues/368 Fixes: 5fb62e9cd3ad ("selftests: mptcp: add tproxy test case") Cc: stable@xxxxxxxxxxxxxxx Signed-off-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -144,6 +144,7 @@ cleanup() } mptcp_lib_check_mptcp +mptcp_lib_check_kallsyms ip -Version > /dev/null 2>&1 if [ $? -ne 0 ];then @@ -696,6 +697,15 @@ run_test_transparent() return 0 fi + # IP(V6)_TRANSPARENT has been added after TOS support which came with + # the required infrastructure in MPTCP sockopt code. To support TOS, the + # following function has been exported (T). Not great but better than + # checking for a specific kernel version. + if ! mptcp_lib_kallsyms_has "T __ip_sock_set_tos$"; then + echo "INFO: ${msg} not supported by the kernel: SKIP" + return + fi + ip netns exec "$listener_ns" nft -f /dev/stdin <<"EOF" flush ruleset table inet mangle { Patches currently in stable-queue which might be from matthieu.baerts@xxxxxxxxxxxx are queue-6.1/selftests-mptcp-join-fix-shellcheck-warnings.patch queue-6.1/selftests-mptcp-join-support-rm_addr-for-used-endpoints-or-not.patch queue-6.1/selftests-mptcp-pm-nl-skip-fullmesh-flag-checks-if-not-supported.patch queue-6.1/selftests-mptcp-lib-skip-if-missing-symbol.patch queue-6.1/selftests-mptcp-join-skip-fullmesh-flag-tests-if-not-supported.patch queue-6.1/selftests-mptcp-join-skip-fastclose-tests-if-not-supported.patch queue-6.1/selftests-mptcp-remove-duplicated-entries-in-usage.patch queue-6.1/selftests-mptcp-sockopt-skip-getsockopt-checks-if-not-supported.patch queue-6.1/selftests-mptcp-join-skip-backup-if-set-flag-on-id-not-supported.patch queue-6.1/selftests-mptcp-userspace-pm-skip-if-ip-tool-is-unavailable.patch queue-6.1/selftests-mptcp-join-helpers-to-skip-tests.patch queue-6.1/selftests-mptcp-lib-skip-if-not-below-kernel-version.patch queue-6.1/selftests-mptcp-userspace-pm-skip-if-not-supported.patch queue-6.1/selftests-mptcp-join-skip-implicit-tests-if-not-supported.patch queue-6.1/selftests-mptcp-sockopt-relax-expected-returned-size.patch queue-6.1/selftests-mptcp-pm-nl-remove-hardcoded-default-limits.patch queue-6.1/selftests-mptcp-join-skip-check-if-mib-counter-not-supported.patch queue-6.1/selftests-mptcp-join-use-iptables-legacy-if-available.patch queue-6.1/selftests-mptcp-join-support-local-endpoint-being-tracked-or-not.patch queue-6.1/selftests-mptcp-connect-skip-transp-tests-if-not-supported.patch queue-6.1/selftests-mptcp-join-skip-mpc-backups-tests-if-not-supported.patch queue-6.1/selftests-mptcp-connect-skip-disconnect-tests-if-not-supported.patch