Patch "igc: Fix possible system crash when loading module" has been added to the 6.1-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    igc: Fix possible system crash when loading module

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     igc-fix-possible-system-crash-when-loading-module.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit aaa7303a5a6199cbcb8c436173495ec7817e724f
Author: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>
Date:   Mon Apr 17 15:18:39 2023 -0700

    igc: Fix possible system crash when loading module
    
    [ Upstream commit c080fe262f9e73a00934b70c16b1479cf40cd2bd ]
    
    Guarantee that when probe() is run again, PTM and PCI busmaster will be
    in the same state as it was if the driver was never loaded.
    
    Avoid an i225/i226 hardware issue that PTM requests can be made even
    though PCI bus mastering is not enabled. These unexpected PTM requests
    can crash some systems.
    
    So, "force" disable PTM and busmastering before removing the driver,
    so they can be re-enabled in the right order during probe(). This is
    more like a workaround and should be applicable for i225 and i226, in
    any platform.
    
    Fixes: 1b5d73fb8624 ("igc: Enable PCIe PTM")
    Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>
    Reviewed-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx>
    Tested-by: Naama Meir <naamax.meir@xxxxxxxxxxxxxxx>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index e5cb76cf2c3f1..3509974c1f8e4 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -6685,6 +6685,9 @@ static void igc_remove(struct pci_dev *pdev)
 
 	igc_ptp_stop(adapter);
 
+	pci_disable_ptm(pdev);
+	pci_clear_master(pdev);
+
 	set_bit(__IGC_DOWN, &adapter->state);
 
 	del_timer_sync(&adapter->watchdog_timer);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux