Patch "selftests/tc-testing: Fix SFB db test" has been added to the 6.3-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    selftests/tc-testing: Fix SFB db test

to the 6.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     selftests-tc-testing-fix-sfb-db-test.patch
and it can be found in the queue-6.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 6ca82858f40b73b6cbc760f6f890417e07e2d66f
Author: Vlad Buslov <vladbu@xxxxxxxxxx>
Date:   Mon Jun 12 09:57:11 2023 +0200

    selftests/tc-testing: Fix SFB db test
    
    [ Upstream commit b39d8c41c7a8336ce85c376b5d4906089524a0ae ]
    
    Setting very small value of db like 10ms introduces rounding errors when
    converting to/from jiffies on some kernel configs. For example, on 250hz
    the actual value will be set to 12ms which causes the test to fail:
    
     # $ sudo ./tdc.py  -d eth2 -e 3410
     #  -- ns/SubPlugin.__init__
     # Test 3410: Create SFB with db setting
     #
     # All test results:
     #
     # 1..1
     # not ok 1 3410 - Create SFB with db setting
     #         Could not match regex pattern. Verify command output:
     # qdisc sfb 1: root refcnt 2 rehash 600s db 12ms limit 1000p max 25p target 20p increment 0.000503548 decrement 4.57771e-05 penalty_rate 10pps penalty_burst 20p
    
    Set the value to 100ms instead which currently seem to work on 100hz,
    250hz, 300hz and 1000hz kernel configs.
    
    Fixes: 6ad92dc56fca ("selftests/tc-testing: add selftests for sfb qdisc")
    Signed-off-by: Vlad Buslov <vladbu@xxxxxxxxxx>
    Reviewed-by: Pedro Tammela <pctammela@xxxxxxxxxxxx>
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfb.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfb.json
index ba2f5e79cdbfe..e21c7f22c6d4c 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfb.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfb.json
@@ -58,10 +58,10 @@
         "setup": [
             "$IP link add dev $DUMMY type dummy || /bin/true"
         ],
-        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfb db 10",
+        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfb db 100",
         "expExitCode": "0",
         "verifyCmd": "$TC qdisc show dev $DUMMY",
-        "matchPattern": "qdisc sfb 1: root refcnt [0-9]+ rehash 600s db 10ms",
+        "matchPattern": "qdisc sfb 1: root refcnt [0-9]+ rehash 600s db 100ms",
         "matchCount": "1",
         "teardown": [
             "$TC qdisc del dev $DUMMY handle 1: root",



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux