This is a note to let you know that I've just added the patch titled Revert "staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE" to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-staging-rtl8192e-replace-macro-rtl_pci_device-with-pci_device.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 47de7971108b44c0c139479358e8ed92f646cbf4 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Mon, 12 Jun 2023 12:06:32 +0200 Subject: Revert "staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE" From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> This reverts commit ec310591cf839653a5b2c1fcf6b8a110c3f2485c which is commit a80f4c7dc4dbd2925cf3da86004137965cb16086 upstream. Ben reports that this should not have been backported to the older kernels as the rest of the macro is not empty. It was a clean-up patch in 6.4-rc1 only, it did not add new device ids. Reported-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> Cc: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> Cc: Sasha Levin <sashal@xxxxxxxxxx> Link: https://lore.kernel.org/r/aa0d401a7f63448cd4c2fe4a2d7e8495d9aa123e.camel@xxxxxxxxxxxxxxx Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -61,9 +61,9 @@ static const struct rtl819x_ops rtl819xp }; static struct pci_device_id rtl8192_pci_id_tbl[] = { - {PCI_DEVICE(0x10ec, 0x8192)}, - {PCI_DEVICE(0x07aa, 0x0044)}, - {PCI_DEVICE(0x07aa, 0x0047)}, + {RTL_PCI_DEVICE(0x10ec, 0x8192, rtl819xp_ops)}, + {RTL_PCI_DEVICE(0x07aa, 0x0044, rtl819xp_ops)}, + {RTL_PCI_DEVICE(0x07aa, 0x0047, rtl819xp_ops)}, {} }; --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -67,6 +67,11 @@ #define IS_HARDWARE_TYPE_8192SE(_priv) \ (((struct r8192_priv *)rtllib_priv(dev))->card_8192 == NIC_8192SE) +#define RTL_PCI_DEVICE(vend, dev, cfg) \ + .vendor = (vend), .device = (dev), \ + .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, \ + .driver_data = (kernel_ulong_t)&(cfg) + #define TOTAL_CAM_ENTRY 32 #define CAM_CONTENT_COUNT 8 Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-4.19/ext4-only-check-dquot_initialize_needed-when-debugging.patch queue-4.19/input-psmouse-fix-oob-access-in-elantech-protocol.patch queue-4.19/bluetooth-fix-use-after-free-in-hci_remove_ltk-hci_remove_irk.patch queue-4.19/btrfs-check-return-value-of-btrfs_commit_transaction-in-relocation.patch queue-4.19/input-xpad-delete-a-razer-deathadder-mouse-vid-pid-entry.patch queue-4.19/revert-staging-rtl8192e-replace-macro-rtl_pci_device-with-pci_device.patch queue-4.19/drm-amdgpu-fix-xclk-freq-on-chip_stoney.patch queue-4.19/i40e-fix-build-warnings-in-i40e_alloc.h.patch queue-4.19/ceph-fix-use-after-free-bug-for-inodes-when-flushing-capsnaps.patch queue-4.19/batman-adv-broken-sync-while-rescheduling-delayed-work.patch queue-4.19/i40iw-fix-build-warning-in-i40iw_manage_apbvt.patch queue-4.19/btrfs-unset-reloc-control-if-transaction-commit-fails-in-prepare_to_relocate.patch queue-4.19/pinctrl-meson-axg-add-missing-gpioa_18-gpio-group.patch