Patch "eeprom: at24: also select REGMAP" has been added to the 6.3-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    eeprom: at24: also select REGMAP

to the 6.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     eeprom-at24-also-select-regmap.patch
and it can be found in the queue-6.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit f6f24af6bbcc71e6089c58d9c4ae341fe4c30f6e
Author: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Date:   Wed Jun 7 19:54:24 2023 -0700

    eeprom: at24: also select REGMAP
    
    [ Upstream commit 7f3c782b3914e510b646a77aedc3adeac2e4a63b ]
    
    Selecting only REGMAP_I2C can leave REGMAP unset, causing build errors,
    so also select REGMAP to prevent the build errors.
    
    ../drivers/misc/eeprom/at24.c:540:42: warning: 'struct regmap_config' declared inside parameter list will not be visible outside of this definition or declaration
      540 |                                   struct regmap_config *regmap_config)
    ../drivers/misc/eeprom/at24.c: In function 'at24_make_dummy_client':
    ../drivers/misc/eeprom/at24.c:552:18: error: implicit declaration of function 'devm_regmap_init_i2c' [-Werror=implicit-function-declaration]
      552 |         regmap = devm_regmap_init_i2c(dummy_client, regmap_config);
    ../drivers/misc/eeprom/at24.c:552:16: warning: assignment to 'struct regmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      552 |         regmap = devm_regmap_init_i2c(dummy_client, regmap_config);
    ../drivers/misc/eeprom/at24.c: In function 'at24_probe':
    ../drivers/misc/eeprom/at24.c:586:16: error: variable 'regmap_config' has initializer but incomplete type
      586 |         struct regmap_config regmap_config = { };
    ../drivers/misc/eeprom/at24.c:586:30: error: storage size of 'regmap_config' isn't known
      586 |         struct regmap_config regmap_config = { };
    ../drivers/misc/eeprom/at24.c:586:30: warning: unused variable 'regmap_config' [-Wunused-variable]
    
    Fixes: 5c015258478e ("eeprom: at24: add basic regmap_i2c support")
    Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
    Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
index f0a7531f354c1..2d240bfa819f8 100644
--- a/drivers/misc/eeprom/Kconfig
+++ b/drivers/misc/eeprom/Kconfig
@@ -6,6 +6,7 @@ config EEPROM_AT24
 	depends on I2C && SYSFS
 	select NVMEM
 	select NVMEM_SYSFS
+	select REGMAP
 	select REGMAP_I2C
 	help
 	  Enable this driver to get read/write support to most I2C EEPROMs



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux