This is a note to let you know that I've just added the patch titled
RDMA/irdma: Do not generate SW completions for NOPs
to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rdma-irdma-do-not-generate-sw-completions-for-nops.patch
and it can be found in the queue-5.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 30ed9ee9a10a90ae719dcfcacead1d0506fa45ed Mon Sep 17 00:00:00 2001
From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
Date: Wed, 15 Mar 2023 09:52:28 -0500
Subject: RDMA/irdma: Do not generate SW completions for NOPs
From: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
commit 30ed9ee9a10a90ae719dcfcacead1d0506fa45ed upstream.
Currently, artificial SW completions are generated for NOP wqes which can
generate unexpected completions with wr_id = 0. Skip the generation of
artificial completions for NOPs.
Fixes: 81091d7696ae ("RDMA/irdma: Add SW mechanism to generate completions on error")
Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>
Signed-off-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx>
Link: https://lore.kernel.org/r/20230315145231.931-2-shiraz.saleem@xxxxxxxxx
Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/infiniband/hw/irdma/utils.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/infiniband/hw/irdma/utils.c
+++ b/drivers/infiniband/hw/irdma/utils.c
@@ -2650,7 +2650,10 @@ void irdma_generate_flush_completions(st
/* remove the SQ WR by moving SQ tail*/
IRDMA_RING_SET_TAIL(*sq_ring,
sq_ring->tail + qp->sq_wrtrk_array[sq_ring->tail].quanta);
-
+ if (cmpl->cpi.op_type == IRDMAQP_OP_NOP) {
+ kfree(cmpl);
+ continue;
+ }
ibdev_dbg(iwqp->iwscq->ibcq.device,
"DEV: %s: adding wr_id = 0x%llx SQ Completion to list qp_id=%d\n",
__func__, cmpl->cpi.wr_id, qp->qp_id);
Patches currently in stable-queue which might be from mustafa.ismail@xxxxxxxxx are
queue-5.15/rdma-irdma-do-not-generate-sw-completions-for-nops.patch
queue-5.15/rdma-irdma-fix-local-invalidate-fencing.patch
queue-5.15/rdma-irdma-add-sw-mechanism-to-generate-completions-.patch
queue-5.15/rdma-irdma-prevent-qp-use-after-free.patch
