89bf72db1b859990355f9c40713a34e0d2d86c98.camel@xxxxxxxxxxxxx> Message-ID: <2023051550-oxidation-elsewhere-8367@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled KVM: Fix steal time asm constraints to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: kvm-fix-steal-time-asm-constraints.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From stable-owner@xxxxxxxxxxxxxxx Wed May 10 20:16:36 2023 From: Rishabh Bhatnagar <risbhat@xxxxxxxxxx> Date: Wed, 10 May 2023 18:15:41 +0000 Subject: KVM: Fix steal time asm constraints To: <gregkh@xxxxxxxxxxxxxxxxxxx>, <stable@xxxxxxxxxxxxxxx> Cc: <lee@xxxxxxxxxx>, <seanjc@xxxxxxxxxx>, <kvm@xxxxxxxxxxxxxxx>, <bp@xxxxxxxxx>, <mingo@xxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <pbonzini@xxxxxxxxxx>, <vkuznets@xxxxxxxxxx>, <wanpengli@xxxxxxxxxxx>, <jmattson@xxxxxxxxxx>, <joro@xxxxxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, kernel test robot <lkp@xxxxxxxxx>, Rishabh Bhatnagar <risbhat@xxxxxxxxxx>, Allen Pais <apais@xxxxxxxxxxxxxxxxxxx> Message-ID: <20230510181547.22451-4-risbhat@xxxxxxxxxx> From: Rishabh Bhatnagar <risbhat@xxxxxxxxxx> From: David Woodhouse <dwmw@xxxxxxxxxxxx> commit 964b7aa0b040bdc6ec1c543ee620cda3f8b4c68a upstream. In 64-bit mode, x86 instruction encoding allows us to use the low 8 bits of any GPR as an 8-bit operand. In 32-bit mode, however, we can only use the [abcd] registers. For which, GCC has the "q" constraint instead of the less restrictive "r". Also fix st->preempted, which is an input/output operand rather than an input. Fixes: 7e2175ebd695 ("KVM: x86: Fix recording of guest steal time / preempted status") Reported-by: kernel test robot <lkp@xxxxxxxxx> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx> Message-Id: <89bf72db1b859990355f9c40713a34e0d2d86c98.camel@xxxxxxxxxxxxx> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> Signed-off-by: Rishabh Bhatnagar <risbhat@xxxxxxxxxx> Tested-by: Allen Pais <apais@xxxxxxxxxxxxxxxxxxx> Acked-by: Sean Christopherson <seanjc@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- arch/x86/kvm/x86.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3064,9 +3064,9 @@ static void record_steal_time(struct kvm "xor %1, %1\n" "2:\n" _ASM_EXTABLE_UA(1b, 2b) - : "+r" (st_preempted), - "+&r" (err) - : "m" (st->preempted)); + : "+q" (st_preempted), + "+&r" (err), + "+m" (st->preempted)); if (err) goto out; Patches currently in stable-queue which might be from stable-owner@xxxxxxxxxxxxxxx are queue-5.10/kvm-fix-steal-time-asm-constraints.patch queue-5.10/kvm-x86-ensure-pv-tlb-flush-tracepoint-reflects-kvm-behavior.patch queue-5.10/blk-crypto-make-blk_crypto_evict_key-more-robust.patch queue-5.10/kvm-x86-do-not-report-preemption-if-the-steal-time-cache-is-stale.patch queue-5.10/kvm-x86-do-not-set-st-preempted-when-going-back-to-user-space.patch queue-5.10/kvm-x86-move-guest_pv_has-out-of-user_access-section.patch queue-5.10/kvm-x86-fix-recording-of-guest-steal-time-preempted-status.patch queue-5.10/blk-mq-release-crypto-keyslot-before-reporting-i-o-complete.patch queue-5.10/kvm-x86-revalidate-steal-time-cache-if-msr-value-changes.patch queue-5.10/blk-crypto-make-blk_crypto_evict_key-return-void.patch queue-5.10/kvm-x86-remove-obsolete-disabling-of-page-faults-in-kvm_arch_vcpu_put.patch