This is a note to let you know that I've just added the patch titled
drm/msm: fix workqueue leak on bind errors
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-msm-fix-workqueue-leak-on-bind-errors.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From a75b49db6529b2af049eafd938fae888451c3685 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan+linaro@xxxxxxxxxx>
Date: Mon, 6 Mar 2023 11:07:20 +0100
Subject: drm/msm: fix workqueue leak on bind errors
From: Johan Hovold <johan+linaro@xxxxxxxxxx>
commit a75b49db6529b2af049eafd938fae888451c3685 upstream.
Make sure to destroy the workqueue also in case of early errors during
bind (e.g. a subcomponent failing to bind).
Since commit c3b790ea07a1 ("drm: Manage drm_mode_config_init with
drmm_") the mode config will be freed when the drm device is released
also when using the legacy interface, but add an explicit cleanup for
consistency and to facilitate backporting.
Fixes: 060530f1ea67 ("drm/msm: use componentised device support")
Cc: stable@xxxxxxxxxxxxxxx # 3.15
Cc: Rob Clark <robdclark@xxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Patchwork: https://patchwork.freedesktop.org/patch/525093/
Link: https://lore.kernel.org/r/20230306100722.28485-9-johan+linaro@xxxxxxxxxx
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_drv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -456,7 +456,7 @@ static int msm_drm_init(struct device *d
ret = msm_init_vram(ddev);
if (ret)
- goto err_put_dev;
+ goto err_cleanup_mode_config;
/* Bind all our sub-components: */
ret = component_bind_all(dev, ddev);
@@ -561,6 +561,9 @@ err_msm_uninit:
err_deinit_vram:
msm_deinit_vram(ddev);
+err_cleanup_mode_config:
+ drm_mode_config_cleanup(ddev);
+ destroy_workqueue(priv->wq);
err_put_dev:
drm_dev_put(ddev);
Patches currently in stable-queue which might be from johan+linaro@xxxxxxxxxx are
queue-6.1/drm-msm-fix-vram-leak-on-bind-errors.patch
queue-6.1/drm-msm-adreno-fix-runtime-pm-imbalance-at-gpu-load.patch
queue-6.1/drm-msm-fix-workqueue-leak-on-bind-errors.patch
queue-6.1/drm-msm-fix-drm-device-leak-on-bind-errors.patch
queue-6.1/drm-msm-fix-null-deref-on-irq-uninstall.patch
queue-6.1/usb-dwc3-gadget-drop-dead-hibernation-code.patch
queue-6.1/drm-msm-fix-null-deref-on-snapshot-tear-down.patch
