This is a note to let you know that I've just added the patch titled
cifs: protect session status check in smb2_reconnect()
to the 6.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cifs-protect-session-status-check-in-smb2_reconnect.patch
and it can be found in the queue-6.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 5bff9f741af60b143a5ae73417a8ec47fd5ff2f4 Mon Sep 17 00:00:00 2001
From: Paulo Alcantara <pc@xxxxxxxxxxxxx>
Date: Thu, 27 Apr 2023 16:07:38 -0300
Subject: cifs: protect session status check in smb2_reconnect()
From: Paulo Alcantara <pc@xxxxxxxxxxxxx>
commit 5bff9f741af60b143a5ae73417a8ec47fd5ff2f4 upstream.
Use @ses->ses_lock to protect access of @ses->ses_status.
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Paulo Alcantara (SUSE) <pc@xxxxxxxxxxxxx>
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/cifs/smb2pdu.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -175,8 +175,17 @@ smb2_reconnect(__le16 smb2_command, stru
}
}
spin_unlock(&tcon->tc_lock);
- if ((!tcon->ses) || (tcon->ses->ses_status == SES_EXITING) ||
- (!tcon->ses->server) || !server)
+
+ ses = tcon->ses;
+ if (!ses)
+ return -EIO;
+ spin_lock(&ses->ses_lock);
+ if (ses->ses_status == SES_EXITING) {
+ spin_unlock(&ses->ses_lock);
+ return -EIO;
+ }
+ spin_unlock(&ses->ses_lock);
+ if (!ses->server || !server)
return -EIO;
spin_lock(&server->srv_lock);
@@ -204,8 +213,6 @@ again:
if (rc)
return rc;
- ses = tcon->ses;
-
spin_lock(&ses->chan_lock);
if (!cifs_chan_needs_reconnect(ses, server) && !tcon->need_reconnect) {
spin_unlock(&ses->chan_lock);
Patches currently in stable-queue which might be from pc@xxxxxxxxxxxxx are
queue-6.3/cifs-protect-access-of-tcp_server_info-origin-leaf-_fullpath.patch
queue-6.3/cifs-avoid-potential-races-when-handling-multiple-dfs-tcons.patch
queue-6.3/cifs-fix-sharing-of-dfs-connections.patch
queue-6.3/cifs-fix-potential-use-after-free-bugs-in-tcp_server_info-hostname.patch
queue-6.3/smb3-add-missing-locks-to-protect-deferred-close-fil.patch
queue-6.3/cifs-fix-potential-race-when-tree-connecting-ipc.patch
queue-6.3/cifs-protect-session-status-check-in-smb2_reconnect.patch
