This is a note to let you know that I've just added the patch titled
ksmbd: fix memleak in session setup
to the 6.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ksmbd-fix-memleak-in-session-setup.patch
and it can be found in the queue-6.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 6d7cb549c2ca20e1f07593f15e936fd54b763028 Mon Sep 17 00:00:00 2001
From: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Date: Wed, 3 May 2023 08:26:45 +0900
Subject: ksmbd: fix memleak in session setup
From: Namjae Jeon <linkinjeon@xxxxxxxxxx>
commit 6d7cb549c2ca20e1f07593f15e936fd54b763028 upstream.
If client send session setup request with unknown NTLMSSP message type,
session that does not included channel can be created. It will cause
session memleak. because ksmbd_sessions_deregister() does not destroy
session if channel is not included. This patch return error response if
client send the request unknown NTLMSSP message type.
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: zdi-disclosures@xxxxxxxxxxxxxx # ZDI-CAN-20593
Signed-off-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/ksmbd/smb2pdu.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -1801,6 +1801,10 @@ int smb2_sess_setup(struct ksmbd_work *w
}
kfree(sess->Preauth_HashValue);
sess->Preauth_HashValue = NULL;
+ } else {
+ pr_info_ratelimited("Unknown NTLMSSP message type : 0x%x\n",
+ le32_to_cpu(negblob->MessageType));
+ rc = -EINVAL;
}
} else {
/* TODO: need one more negotiation */
Patches currently in stable-queue which might be from linkinjeon@xxxxxxxxxx are
queue-6.2/ksmbd-not-allow-guest-user-on-multichannel.patch
queue-6.2/ksmbd-fix-memleak-in-session-setup.patch
queue-6.2/ksmbd-fix-null-pointer-dereference-in-smb2_get_info_filesystem.patch
queue-6.2/ksmbd-fix-racy-issue-under-cocurrent-smb2-tree-disconnect.patch
queue-6.2/ksmbd-fix-deadlock-in-ksmbd_find_crypto_ctx.patch
queue-6.2/ksmbd-call-rcu_barrier-in-ksmbd_server_exit.patch
