This is a note to let you know that I've just added the patch titled
soc: sifive: l2_cache: fix missing of_node_put() in sifive_l2_init()
to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
soc-sifive-l2_cache-fix-missing-of_node_put-in-sifive_l2_init.patch
and it can be found in the queue-5.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From stable-owner@xxxxxxxxxxxxxxx Mon Apr 24 11:19:51 2023
From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Date: Mon, 24 Apr 2023 10:19:04 +0100
Subject: soc: sifive: l2_cache: fix missing of_node_put() in sifive_l2_init()
To: <stable@xxxxxxxxxxxxxxx>
Cc: <conor@xxxxxxxxxx>, <conor.dooley@xxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Greentime Hu <greentime.hu@xxxxxxxxxx>, Zong Li <zong.li@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxxx>, Sasha Levin <sashal@xxxxxxxxxx>, Yang Yingliang <yangyingliang@xxxxxxxxxx>
Message-ID: <20230424-shading-breeze-0d4b62b0dc55@wendy>
From: Yang Yingliang <yangyingliang@xxxxxxxxxx>
commit 8fbf94fea0b4e187ca9100936c5429f96b8a4e44 upstream.
The device_node pointer returned by of_find_matching_node() with
refcount incremented, when finish using it, the refcount need be
decreased.
Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
[conor: cache -> l2_cache]
Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/soc/sifive/sifive_l2_cache.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
--- a/drivers/soc/sifive/sifive_l2_cache.c
+++ b/drivers/soc/sifive/sifive_l2_cache.c
@@ -202,12 +202,16 @@ static int __init sifive_l2_init(void)
if (!np)
return -ENODEV;
- if (of_address_to_resource(np, 0, &res))
- return -ENODEV;
+ if (of_address_to_resource(np, 0, &res)) {
+ rc = -ENODEV;
+ goto err_node_put;
+ }
l2_base = ioremap(res.start, resource_size(&res));
- if (!l2_base)
- return -ENOMEM;
+ if (!l2_base) {
+ rc = -ENOMEM;
+ goto err_node_put;
+ }
intr_num = of_property_count_u32_elems(np, "interrupts");
if (!intr_num) {
@@ -224,6 +228,7 @@ static int __init sifive_l2_init(void)
goto err_free_irq;
}
}
+ of_node_put(np);
l2_config_read();
@@ -240,6 +245,8 @@ err_free_irq:
free_irq(g_irq[i], NULL);
err_unmap:
iounmap(l2_base);
+err_node_put:
+ of_node_put(np);
return rc;
}
device_initcall(sifive_l2_init);
Patches currently in stable-queue which might be from stable-owner@xxxxxxxxxxxxxxx are
queue-5.15/sched-fair-detect-capacity-inversion.patch
queue-5.15/soc-sifive-l2_cache-fix-missing-iounmap-in-error-path-in-sifive_l2_init.patch
queue-5.15/pwm-hibvt-explicitly-set-.polarity-in-.get_state.patch
queue-5.15/pwm-iqs620a-explicitly-set-.polarity-in-.get_state.patch
queue-5.15/sched-uclamp-make-cpu_overutilized-use-util_fits_cpu.patch
queue-5.15/sched-uclamp-fix-fits_capacity-check-in-feec.patch
queue-5.15/soc-sifive-l2_cache-fix-missing-of_node_put-in-sifive_l2_init.patch
queue-5.15/sched-fair-consider-capacity-inversion-in-util_fits_cpu.patch
queue-5.15/sched-fair-fixes-for-capacity-inversion-detection.patch
queue-5.15/sched-uclamp-fix-a-uninitialized-variable-warnings.patch
queue-5.15/soc-sifive-l2_cache-fix-missing-free_irq-in-error-path-in-sifive_l2_init.patch
queue-5.15/sched-uclamp-cater-for-uclamp-in-find_energy_efficient_cpu-s-early-exit-condition.patch
