This is a note to let you know that I've just added the patch titled
ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and iMac14,2
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-video-add-acpi_backlight-video-quirk-for-apple-imac14-1-and-imac14-2.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 2699107989431d6db44f8a9e809ea74c387336d1 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@xxxxxxxxxx>
Date: Tue, 4 Apr 2023 13:02:48 +0200
Subject: ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and iMac14,2
From: Hans de Goede <hdegoede@xxxxxxxxxx>
commit 2699107989431d6db44f8a9e809ea74c387336d1 upstream.
On the Apple iMac14,1 and iMac14,2 all-in-ones (monitors with builtin "PC")
the connection between the GPU and the panel is seen by the GPU driver as
regular DP instead of eDP, causing the GPU driver to never call
acpi_video_register_backlight().
(GPU drivers only call acpi_video_register_backlight() when an internal
panel is detected, to avoid non working acpi_video# devices getting
registered on desktops which unfortunately is a real issue.)
Fix the missing acpi_video# backlight device on these all-in-ones by
adding a acpi_backlight=video DMI quirk, so that video.ko will
immediately register the backlight device instead of waiting for
an acpi_video_register_backlight() call.
Fixes: 5aa9d943e9b6 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default")
Cc: All applicable <stable@xxxxxxxxxxxxxxx>
Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/acpi/video_detect.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -275,6 +275,29 @@ static const struct dmi_system_id video_
},
/*
+ * Models which need acpi_video backlight control where the GPU drivers
+ * do not call acpi_video_register_backlight() because no internal panel
+ * is detected. Typically these are all-in-ones (monitors with builtin
+ * PC) where the panel connection shows up as regular DP instead of eDP.
+ */
+ {
+ .callback = video_detect_force_video,
+ /* Apple iMac14,1 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac14,1"),
+ },
+ },
+ {
+ .callback = video_detect_force_video,
+ /* Apple iMac14,2 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac14,2"),
+ },
+ },
+
+ /*
* These models have a working acpi_video backlight control, and using
* native backlight causes a regression where backlight does not work
* when userspace is not handling brightness key events. Disable
Patches currently in stable-queue which might be from hdegoede@xxxxxxxxxx are
queue-6.1/platform-x86-think-lmi-clean-up-display-of-current_v.patch
queue-6.1/platform-x86-think-lmi-fix-memory-leak-when-showing-.patch
queue-6.1/wifi-brcmfmac-fix-sdio-suspend-resume-regression.patch
queue-6.1/platform-x86-think-lmi-fix-memory-leaks-when-parsing.patch
queue-6.1/acpi-video-add-auto_detect-arg-to-__acpi_video_get_backlight_type.patch
queue-6.1/acpi-video-add-acpi_backlight-video-quirk-for-apple-imac14-1-and-imac14-2.patch
queue-6.1/serial-8250-prevent-starting-up-dma-rx-on-thri-interrupt.patch
queue-6.1/iio-light-cm32181-unregister-second-i2c-client-if-present.patch
queue-6.1/acpi-video-add-acpi_backlight-video-quirk-for-lenovo-thinkpad-w530.patch
queue-6.1/acpi-video-make-acpi_backlight-video-work-independent-from-gpu-driver.patch
