Patch "net: hsr: Don't log netdev_err message on unknown prp dst node" has been added to the 5.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: hsr: Don't log netdev_err message on unknown prp dst node

to the 5.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-hsr-don-t-log-netdev_err-message-on-unknown-prp-.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit d0005d7ed0c128361e56ed0f82fa5f659817c3ff
Author: Kristian Overskeid <koverskeid@xxxxxxxxx>
Date:   Tue Mar 7 14:32:29 2023 +0100

    net: hsr: Don't log netdev_err message on unknown prp dst node
    
    [ Upstream commit 28e8cabe80f3e6e3c98121576eda898eeb20f1b1 ]
    
    If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the
    node will be deleted from the node_db list. If a frame is sent to the node
    after it is deleted, a netdev_err message for each slave interface is
    produced. This should not happen with dan nodes because of supervision
    frames, but can happen often with san nodes, which clutters the kernel
    log. Since the hsr protocol does not support sans, this is only relevant
    for the prp protocol.
    
    Signed-off-by: Kristian Overskeid <koverskeid@xxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
index 20cb6b7dbc694..08627c8368848 100644
--- a/net/hsr/hsr_framereg.c
+++ b/net/hsr/hsr_framereg.c
@@ -380,7 +380,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
 	node_dst = find_node_by_addr_A(&port->hsr->node_db,
 				       eth_hdr(skb)->h_dest);
 	if (!node_dst) {
-		if (net_ratelimit())
+		if (net_ratelimit() && port->hsr->prot_version != PRP_V1)
 			netdev_err(skb->dev, "%s: Unknown node\n", __func__);
 		return;
 	}



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux