Patch "kconfig: Update config changed flag before calling callback" has been added to the 6.2-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    kconfig: Update config changed flag before calling callback

to the 6.2-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     kconfig-update-config-changed-flag-before-calling-ca.patch
and it can be found in the queue-6.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5326a08ded2f1f95b0707196edab61338b601cc6
Author: Jurica Vukadin <jura@xxxxxxxx>
Date:   Tue Mar 7 20:40:39 2023 +0100

    kconfig: Update config changed flag before calling callback
    
    [ Upstream commit ee06a3ef7e3cddb62b90ac40aa661d3c12f7cabc ]
    
    Prior to commit 5ee546594025 ("kconfig: change sym_change_count to a
    boolean flag"), the conf_updated flag was set to the new value *before*
    calling the callback. xconfig's save action depends on this behaviour,
    because xconfig calls conf_get_changed() directly from the callback and
    now sees the old value, thus never enabling the save button or the
    shortcut.
    
    Restore the previous behaviour.
    
    Fixes: 5ee546594025 ("kconfig: change sym_change_count to a boolean flag")
    Signed-off-by: Jurica Vukadin <jura@xxxxxxxx>
    Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
    Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
    Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index b7c9f1dd5e422..992575f1e9769 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -1226,10 +1226,12 @@ static void (*conf_changed_callback)(void);
 
 void conf_set_changed(bool val)
 {
-	if (conf_changed_callback && conf_changed != val)
-		conf_changed_callback();
+	bool changed = conf_changed != val;
 
 	conf_changed = val;
+
+	if (conf_changed_callback && changed)
+		conf_changed_callback();
 }
 
 bool conf_get_changed(void)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux