This is a note to let you know that I've just added the patch titled wifi: cfg80211: Partial revert "wifi: cfg80211: Fix use after free for wext" to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: wifi-cfg80211-partial-revert-wifi-cfg80211-fix-use-after-free-for-wext.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 79d1ed5ca7db67d48e870c979f0e0f6b0947944a Mon Sep 17 00:00:00 2001 From: Hector Martin <marcan@xxxxxxxxx> Date: Sat, 11 Mar 2023 23:19:14 +0900 Subject: wifi: cfg80211: Partial revert "wifi: cfg80211: Fix use after free for wext" From: Hector Martin <marcan@xxxxxxxxx> commit 79d1ed5ca7db67d48e870c979f0e0f6b0947944a upstream. This reverts part of commit 015b8cc5e7c4 ("wifi: cfg80211: Fix use after free for wext") This commit broke WPA offload by unconditionally clearing the crypto modes for non-WEP connections. Drop that part of the patch. Signed-off-by: Hector Martin <marcan@xxxxxxxxx> Reported-by: Ilya <me@xxxxxxxx> Reported-and-tested-by: Janne Grunau <j@xxxxxxxxxx> Reviewed-by: Eric Curtin <ecurtin@xxxxxxxxxx> Fixes: 015b8cc5e7c4 ("wifi: cfg80211: Fix use after free for wext") Cc: stable@xxxxxxxxxx Link: https://lore.kernel.org/linux-wireless/ZAx0TWRBlGfv7pNl@xxxxxxxxx/T/#m11e6e0915ab8fa19ce8bc9695ab288c0fe018edf Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- net/wireless/sme.c | 2 -- 1 file changed, 2 deletions(-) --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -1252,8 +1252,6 @@ int cfg80211_connect(struct cfg80211_reg connect->key = NULL; connect->key_len = 0; connect->key_idx = 0; - connect->crypto.cipher_group = 0; - connect->crypto.n_ciphers_pairwise = 0; } wdev->connect_keys = connkeys; Patches currently in stable-queue which might be from marcan@xxxxxxxxx are queue-5.4/wifi-cfg80211-partial-revert-wifi-cfg80211-fix-use-after-free-for-wext.patch